Update Microsoft.Build package references#11518
Closed
Redth wants to merge 1 commit into
Closed
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to centralize/upgrade MSBuild-related package versions and ensure Microsoft.Android.Build.BaseTasks has an explicit System.Reflection.Metadata dependency during restore/build.
Changes:
- Added a new
MSBuildPackageReferenceVersionproperty (intended for MSBuild package versioning). - Added a conditional
PackageReferencetoSystem.Reflection.Metadatafor theMicrosoft.Android.Build.BaseTasksproject.
Comment on lines
51
to
56
| <NuGetApiPackageVersion>5.4.0</NuGetApiPackageVersion> | ||
| <LZ4PackageVersion>1.3.6</LZ4PackageVersion> | ||
| <MicrosoftTestingPlatformVersion>2.2.1</MicrosoftTestingPlatformVersion> | ||
| <MSBuildPackageReferenceVersion>18.6.3</MSBuildPackageReferenceVersion> | ||
| <MonoOptionsVersion>6.12.0.148</MonoOptionsVersion> | ||
| <SystemCollectionsImmutableVersion>8.0.0</SystemCollectionsImmutableVersion> |
Member
Author
There was a problem hiding this comment.
This is used in the xamarin-android-tools submodule.
Member
There was a problem hiding this comment.
I think it has a point, that we needed to update the other repo:
But there is something weird going on with System.Reflection.Metadata, like they removed a transitive dependency.
Member
|
Closing in favor of: Reading the changes here, copilot was making up stuff because it was in the wrong repo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation