[BaseTasks] Bump System.Reflection.Metadata to match Microsoft.Build 18.6.3#376
Closed
jonathanpeppers wants to merge 1 commit into
Closed
[BaseTasks] Bump System.Reflection.Metadata to match Microsoft.Build 18.6.3#376jonathanpeppers wants to merge 1 commit into
jonathanpeppers wants to merge 1 commit into
Conversation
…18.6.3 Microsoft.Build.Tasks.Core 18.6.3 transitively requires System.Reflection.Metadata >= 11.0.0-preview.1.26104.118, but the default in MSBuildReferences.projitems was still 10.0.3. This causes NU1605 package-downgrade errors in consuming repos that do not override SystemReflectionMetadataPackageVersion (e.g. android-platform-support). This should have been updated in a2ddf1a / PR #369 when MSBuild was bumped to 18.6.3. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the centralized BaseTasks MSBuild dependency versions to prevent NU1605 downgrade errors in downstream repos by aligning System.Reflection.Metadata with the transitive minimum required by Microsoft.Build.Tasks.Core 18.6.3.
Changes:
- Bump
SystemReflectionMetadataPackageVersionfrom10.0.3to11.0.0-preview.1.26104.118inMSBuildReferences.projitems.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bump
SystemReflectionMetadataPackageVersionfrom10.0.3to11.0.0-preview.1.26104.118inMSBuildReferences.projitems.Problem
Microsoft.Build.Tasks.Core 18.6.3transitively requiresSystem.Reflection.Metadata >= 11.0.0-preview.1.26104.118, but the default inMSBuildReferences.projitemswas still10.0.3. This causes NU1605 package-downgrade errors in consuming repos that do not overrideSystemReflectionMetadataPackageVersion(e.g.android-platform-support), which broke the internal build after the submodule bump in dotnet/android#11521.Root cause
This should have been updated in a2ddf1a / PR #369 when MSBuild was bumped to 18.6.3, but the SRM version was missed.