[copilot] allow copilot-setup-steps.yml to fail
#1193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We found Copilot can go off track if: * Copilot commits a build error (of any kind). * You comment suggesting how to fix the build error. * Copilot setup steps will now fail, and Copilot can't fix it! So, once you are in this state, you can't really get Copilot back on track unless you manually fix it. Going forward, we should: * Allow the "build" step to fail * Upload the logs as an artifact Copilot should be able to do its work with a failing build. Also, update to .NET 9.
Member
Author
This reverts commit f472fdf.
Member
Author
|
Ok, latest one works with no disk space issues: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We found Copilot can go off track if:
So, once you are in this state, you can't really get Copilot back on track unless you manually fix it.
Going forward, we should:
Copilot should be able to do its work with a failing build.
Also, update to .NET 9.