Refactored codebase to make more extensive use of more modern C# features. #61
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #60
This PR refactors the XAML Studio codebase to make more extensive use of modern C# features. The refactor was performed using various Roslyn analyzers. All transformations to the code were carefully reviewed, and reformatted where necessary to follow the conventions of adjacent code.
For the most part, this is a "pure" refactor, but a couple semantic changes are included:
ActivationHandlerwas updated to avoid theis/asanti-pattern.MainWindowViewModel.OpenDocumentwas updated to await theOpenFilecall and theCloseWelcomeScreencall was removed asOpenFilealready calls it.I am also not sure about the constructor comment moved to the top of
XamlRenderResultContextfollowing the promotion to primary constructor. It's a little awkward, but I left it.PR Type
What kind of change does this PR introduce?
What is the current behavior?
No significant behavioral changes.
What is the new behavior?
No significant behavioral changes.
PR Checklist
Please check if your PR fulfills the following requirements:
Other information