Skip to content

Avoid NullRefereceExceptions when no document open #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mrlacey wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Avoid NullRefereceExceptions when no document open #57

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2bbfaa7
Fix NRE when click "Data" with no document open
mrlacey Jan 8, 2026
88d038e
Avoid NRE when click "Properties" with no document open
mrlacey Jan 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions XamlStudio/Views/DataSources.xaml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,11 @@ private void DataSources_Loaded(object sender, RoutedEventArgs e)

public void Receive(ActiveDocumentViewModelChangedMessage message)
{
if (message.NewDocVM is null)
{
return;
}

// Update are shadow-copy based on MainViewModel
_activeDocument = message.NewDocVM.Document;
ActiveDataContext = _activeDocument.DataContext;
Expand Down
2 changes: 1 addition & 1 deletion XamlStudio/Views/Properties.xaml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ private void Properties_Loaded(object sender, Windows.UI.Xaml.RoutedEventArgs e)
WeakReferenceMessenger.Default.RegisterAll(this);

// Check if there's a render and initialize our existing state
if (MainViewModel.ActiveDocumentViewModel.HasCompiled)
if (MainViewModel.ActiveDocumentViewModel?.HasCompiled ?? false)
{
Receive(new XamlRenderedMessage(MainViewModel.ActiveDocumentViewModel.Result));
}
Expand Down