Feature | Fix enhanced routing ack handling#3972
Closed
mdaigle wants to merge 1 commit intodev/mdaigle/enhanced-routing-2from
Closed
Feature | Fix enhanced routing ack handling#3972mdaigle wants to merge 1 commit intodev/mdaigle/enhanced-routing-2from
mdaigle wants to merge 1 commit intodev/mdaigle/enhanced-routing-2from
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request ports enhanced routing acknowledgment handling fixes from PR #3922 to the main branch. The changes ensure that enhanced routing information (which includes a database name) is only used when the server explicitly acknowledges support for the feature via a feature extension acknowledgment token.
Changes:
- Refactored enhanced routing unit tests to reduce duplication and improve maintainability using a helper class
- Added validation logic to ignore enhanced routing info when the server doesn't acknowledge the feature
- Modified OnFeatureExtAck to process enhanced routing acknowledgments even when routing info is present
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| ConnectionEnhancedRoutingTests.cs | Refactored tests to use TestRoutingServers helper class; consolidated three separate tests into two parameterized tests covering both sync/async paths and various server behaviors |
| SqlConnectionInternal.cs | Added enhanced routing validation checks in LoginNoFailover and LoginWithFailover; updated OnFeatureExtAck to allow processing of enhanced routing acknowledgments alongside DNS caching |
mdaigle
changed the title
mdaigle
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports #3922 to main