Skip to content

Add EBCDIC930 collation tests for SqlClient #3966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
SaiPrasadKousika wants to merge 1 commit into
base: main
Choose a base branch
from
+1,009 −2
Draft

Add EBCDIC930 collation tests for SqlClient #3966

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/Microsoft.Data.SqlClient/tests/ManualTests/Microsoft.Data.SqlClient.ManualTests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,8 +227,7 @@
<Compile Include="SQL\UdtTest\UdtTest.cs" />
<Compile Include="SQL\UdtTest\UdtTest2.cs" />
<Compile Include="SQL\UdtTest\UdtTestHelpers.cs" />
<Compile Include="SQL\Utf8SupportTest\Utf8SupportTest.cs" />
<Compile Include="SQL\VectorTest\NativeVectorFloat32Tests.cs" />
<Compile Include="SQL\Utf8SupportTest\Utf8SupportTest.cs" /> <Compile Include="SQL\CollationTests\EBCDIC930CollationTest.cs" /> <Compile Include="SQL\VectorTest\NativeVectorFloat32Tests.cs" />
Copy link
Author

@SaiPrasadKousika SaiPrasadKousika Feb 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: update indentation

Copy link

Copilot AI Feb 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line contains three separate <Compile> entries on a single line, which breaks the formatting pattern used throughout the rest of the file. Each <Compile> entry should be on its own line for consistency and readability.

Suggested change
<Compile Include="SQL\Utf8SupportTest\Utf8SupportTest.cs" /> <Compile Include="SQL\CollationTests\EBCDIC930CollationTest.cs" /> <Compile Include="SQL\VectorTest\NativeVectorFloat32Tests.cs" />
<Compile Include="SQL\Utf8SupportTest\Utf8SupportTest.cs" />
<Compile Include="SQL\CollationTests\EBCDIC930CollationTest.cs" />
<Compile Include="SQL\VectorTest\NativeVectorFloat32Tests.cs" />

Copilot uses AI. Check for mistakes.
<Compile Include="SQL\VectorTest\VectorAPIValidationTest.cs" />
<Compile Include="SQL\VectorTest\VectorTypeBackwardCompatibilityTests.cs" />
<Compile Include="SQL\WeakRefTest\WeakRefTest.cs" />
Expand Down
Loading
Loading