[3.0] Update SDL and ClangSharp#2570
Open
Exanite wants to merge 44 commits intodevelop/3.0from
Open
Conversation
Contributor
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against ad14c0e |
7 tasks
Exanite
force-pushed
the
feature/update-sdl
branch
from
8622118 to
dc21675
Compare
CMAKE_LIBRARY_ARCHITECTURE fixes the issue where system libraries weren't being found. Eg: "SDL_X11 (Wanted: ON): ON" was OFF without this setting. Eg: "Found OpenGL: /usr/lib/x86_64-linux-gnu/libOpenGL.so " was a not found error without this setting. I removed the pkg-config settings since they didn't seem to do anything and I couldn't figure out if they were correct in the first place. I'm assuming CMake figures these out automatically (it should automatically find the host version of the pkg-config executable and I'm *assuming* (please verify) it uses the CMAKE_LIBRARY_ARCHITECTURE variable to figure out which set of .pc files to use).
x64/amd64 is handled the same way for consistency.
…x package resolution issues
Contributor
|
All native library builds modified in this PR shall attempt to be built by CI. |
(cherry picked from commit ecc5677)
…e, but dependencies first by default is most consistent) (cherry picked from commit ad2d940)
…'s native build process
apt-get seems to be recommended over apt for scripting purposes. apt is designed for humans and does not guarantee backwards compatibility. See https://manpages.debian.org/stretch/apt/apt.8.en.html
Contributor
|
Some of the native library builds modified in this PR were not referenced in the PR description. Please ensure that the PR description contains |
Exanite
commented
Apr 30, 2026
Member
Author
Exanite
left a comment
Exanite
left a comment
There was a problem hiding this comment.
Self code review completed for the new changes I added.
Should be ready for review and merging now.
4 tasks
curin
approved these changes
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the PR
This PR updates ClangSharp and SDL. This was originally part of #2567, but proved to be a more involved change than anticipated due to SDL build problems.
Related issues, Discord discussions, or proposals
This will fix #2402
This PR should also be closed since this PR effectively supersedes it: #2433
Further Comments
Tasks
Native builds
(Currently disabling this command by adding a space; the builds are already committed so there's no reason to run them again)
/ build-native SDL OpenAL-Soft