-
-
Notifications
You must be signed in to change notification settings - Fork 444
[3.0] Improve handling of affixed names when singularizing (OES/SGIS issue) and expose NameAffix API #2535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Exanite
merged 13 commits into
dotnet:develop/3.0
from
Exanite:fix/vendor-suffix-singularize-interaction
Jan 24, 2026
Merged
[3.0] Improve handling of affixed names when singularizing (OES/SGIS issue) and expose NameAffix API #2535
Exanite
merged 13 commits into
dotnet:develop/3.0
from
Exanite:fix/vendor-suffix-singularize-interaction
Jan 24, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… prefix; Rewrite StripAffixes to not allocate; Update PrettifyNames to use new GetAffixes method
6b7c293 to
589792e
Compare
… the AddNameAffix method instead of AddNameSuffix/Prefix separately
Exanite
commented
Jan 15, 2026
Member
Author
Exanite
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Self review completed
sources/SilkTouch/SilkTouch/Mods/Transformation/ArrayParameterTransformer.cs
Show resolved
Hide resolved
curin
approved these changes
Jan 20, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the PR
This fixes the interaction between Khronos vendor suffixes and the Singularize method, which led to cases like the following:
In order to fix this, this also exposes the NameAffix API, allowing mods to read NameAffix attributes and process the name without the affixes attached.
Related issues, Discord discussions, or proposals
Original Discord discussion: https://discord.com/channels/521092042781229087/1376331581198827520/1456785841753035005
Further Comments
Todo list:
OESand similar from being singularizing intoOinArrayParameterTransformer.TransformArrayParameterRewriter.glFeedbackBufferxOESTransformArrayParameterRewritercan singularize the base name instead of the full name.OES(incorrect version isOOES)SGIS(incorrect version isSgiSGIS)NameAffixdata.AddNameAffixAPI to use the newNameAffixTypeenum for consistency and simplicity