feat(categories): migrate Categories portlet from Dojo to Angular

[hmoreras]

Summary

This PR migrates the Categories portlet from the legacy Dojo/Java-server implementation to a modern Angular portlet using PrimeNG and NgRx Signals. It is extracted from the broader PrimeNG migration branch (dot-categories) and rebased on top of main.

Closes #34731

What changed

• New portlet at libs/portlets/dot-categories/ replacing the old implementation in apps/dotcms-ui/src/app/portlets/dot-categories/
• Service moved to libs/data-access/src/lib/dot-categories/ and registered in the shared data-access index
• Features implemented:
  • TreeTable-style list with pagination, sorting, and search/filter with debounce
  • Breadcrumb navigation — click a row to drill into children; breadcrumbs update in-memory state
  • Create/Edit dialog (single component, two modes via DynamicDialogConfig.data)
  • Context menu per row (Edit, Permissions, Delete) — visible only on hover
  • Bulk delete with confirmation dialog
  • CSV import via drag-and-drop upload dialog
  • CSV export
  • Permissions placeholder dialog (wired to future implementation)
• All user-facing text uses i18n keys via DotMessagePipe
• Tests included for store, list component, create component, and import component

Checklist

• Tests
• Translations
• Security Implications Contemplated (add notes if applicable)

[claude]

Claude finished @hmoreras's task in 2m 42s —— View job

---

PR Review — feat(categories): migrate Categories portlet from Dojo to Angular

• Read store implementation
• Read service layer
• Read list component
• Read create/import components
• Review tests
• Post findings

---

Issues Found

1. Dead code: store.importCategories() is never called

DotCategoriesListStore exposes an importCategories(file, exportType) method (store.ts:192-197), but it's never used. DotCategoriesImportComponent calls DotCategoriesService directly (import component:48). The list component then calls store.loadCategories() on dialog close. This violates the portlet architecture rule ("Store MUST NOT open dialogs" / component passes data to store), creates two HTTP paths for the same operation, and the store method is dead code. Either remove store.importCategories() or have the import dialog just return the file+type and let the list component pass them to the store, consistent with how create/edit dialogs work. Fix this →

2. confirmDeleteSingle silently overwrites existing selection

list component:196-199:

accept: () => {
    this.store.setSelectedCategories([category]);  // ← clobbers any existing selection
    this.store.deleteCategories();
}

If a user selects 5 categories via checkboxes, then right-clicks a different row and picks Delete from the context menu, the 5-item selection is silently replaced. The bulk-delete path (confirmDelete()) correctly uses the existing selection. Single-delete should call the service with a targeted inode instead. Fix this →

3. updateSortOrder response is ignored; partial delete failures are swallowed

• Sort order: updateSortOrder API returns DotCMSAPIResponse<DotCategory[]> (the refreshed page), but the success callback only shows a toast (store.ts:229-234). If the server reorders items differently than the optimistic update, the UI is stale until next page change.

• Bulk delete: deleteCategories API returns { successCount, fails }, but handleCategoryAction discards the response. If some categories fail to delete (partial failure), the user gets no feedback. Fix this →

4. navigateToBreadcrumb unsafe cast hides potential undefined parentInode

store.ts:150:

const parentInode = breadcrumbs[breadcrumbs.length - 1]?.id as string;

If index is out of bounds (e.g., breadcrumbs.length - 1 after slicing produces an empty array), parentInode becomes undefined as string. This gets passed to getChildrenPaginated as the inode, producing a bad API call. The optional chain ?.id correctly evaluates to undefined but the as string cast hides it from TypeScript. Fix this →

5. Breadcrumb click uses indexOf (reference equality) which can silently return -1

template line 47:

(onItemClick)="onBreadcrumbClick($any($event).item ? store.breadcrumbs().indexOf($any($event).item) : -1)"

indexOf uses reference equality. If PrimeNG creates a new object for the event's item (which it may do depending on how it passes the model), it won't match and -1 is returned, navigating to root instead of the intended level. The $any() also bypasses type safety on a critical navigation path. Use the breadcrumb's id field to find the index instead. Fix this →

6. MessageService injected in store without being in component providers

store.ts:53 injects MessageService from PrimeNG. The list component's providers array has [DotCategoriesListStore, DialogService, ConfirmationService] (list.ts:69) — MessageService is absent. If a parent or root doesn't provide it, the sort-order save toast will throw a NullInjectorError at runtime. Add MessageService to the component's providers array or verify it's always root-provided.

7. updateSortOrder not tested in the store spec

The store spec (dot-categories-list.store.spec.ts) has no describe('updateSortOrder') block. It's one of the more complex methods (optimistic update, error rollback, toast on success) and is not covered at all. Fix this →

8. exportCategories URL built with string concatenation instead of HttpParams

service.ts:107-110:

let url = '/api/v1/categories/_export';
if (contextInode) {
    url += `?contextInode=${contextInode}`;
}

Inconsistent with every other method in the same file that uses #buildParams() / HttpParams. Inodes are UUIDs so XSS risk is low, but the inconsistency is worth fixing. Use HttpClient.get with params like the rest of the service.

---

Minor

• toCamelCaseVarName('') returns "" — if the backend enforces a non-empty velocity var name, submitting a category whose name is all special characters (e.g., !!!) will fail silently at the API level.
• importType in DotCategoriesImportComponent is a plain mutable property ('replace' | 'merge' = 'merge'), not a signal. With ChangeDetectionStrategy.OnPush this should work via template binding events, but mixing mutation styles in a signals-first component is worth flagging.
• The DotCategoriesPermissionsPlaceholderComponent is defined in the same file as the list component (non-exported, private to the file) — acceptable but unusual; a comment explaining it's intentionally temporary would help.