33073 rxjs from v6 to v7 by nicobytes · Pull Request #35145 · dotCMS/core

nicobytes · 2026-03-27T16:00:32Z

This pull request focuses on migrating the codebase away from deprecated RxJS 6 patterns to be fully compatible with RxJS 7.8.2. The changes are primarily aimed at replacing deprecated operators like pluck, switchMapTo, and publishLast with their recommended alternatives, as well as updating test code to align with newer RxJS error handling APIs. The refactor touches a wide range of files, particularly in the dotcms-ui app, and ensures improved maintainability and future compatibility.

RxJS Operator Refactoring:

Replaced deprecated pluck operator with map across all usages in the codebase, updating selector logic accordingly [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12].
Replaced deprecated switchMapTo with switchMap in all affected streams, updating function signatures where necessary [1] [2] [3].
Replaced deprecated publishLast/refCount combo with shareReplay for caching HTTP responses [1] [2].
Updated usages of pluck in service methods to map, ensuring type safety and clarity.

Test and Error Handling Updates:

Updated all usages of throwError(error) to the RxJS 7+ pattern throwError(() => error) in tests and services for proper error emission [1] [2] [3] [4] [5].

Testing Utilities Modernization:

Replaced deprecated fakeAsync/tick usage with Jest timer mocks (jest.useFakeTimers, jest.advanceTimersByTime, jest.useRealTimers) in component tests for more robust async testing [1] [2] [3] [4].

Documentation:

Added .cursor/plans/rxjs_7_migration_plan_c65e7afc.plan.md to document the migration plan and provide an overview of the categories and scope of changes.

This PR fixes: #33073

…ger field in package.json

claude · 2026-03-27T16:01:23Z

Claude finished @nicobytes's task in 3m 44s —— View job

PR Review: RxJS v6 → v7 Migration

Read flagged files for throwError misuse in tapResponse
Check type mismatches in service files
Review other migration changes

Bug: `getFormIndetifier` — regression in property access

File: core-web/libs/portlets/edit-ema/portlet/src/lib/services/dot-page-api.service.ts:157

The migration changed pluck to map, but picked up the typo from the type definition rather than the actual property name that was being accessed:

- .pipe(pluck('entity', 'content', 'identifier'));   // ← 'identifier' (correct)
+ .pipe(map((x) => x?.entity?.content?.idenfitier)); // ← 'idenfitier' (typo from the type)

The old pluck('entity', 'content', 'identifier') was accessing the correctly-spelled identifier property that the API returns. The new code follows the misspelled field name in the type definition (idenfitier). If the API actually returns identifier, the new code will silently return undefined, breaking the "add form to page" feature.

Fix: either correct the type to identifier and use map((x) => x?.entity?.content?.identifier), or verify what the server actually sends.

Fix this →

Minor: `shareReplay` ordering in `dot-menu.service.ts`

File: core-web/apps/dotcms-ui/src/app/api/services/dot-menu.service.ts:63

this.menu$ = this.http.get<DotCMSResponse<DotMenu[]>>(this.urlMenus).pipe(
    shareReplay({ bufferSize: 1, refCount: true }),  // ← caches raw HTTP response
    map((x) => x.entity)                             // ← transforms per subscriber
);

shareReplay is placed before map, so the raw HTTP response is what's cached. The map transformation runs independently per subscriber. For a single-emission HTTP observable this works correctly, but the conventional pattern is to shareReplay after map so the already-transformed value is replayed. Not a bug given the HTTP use case, but worth considering.

Copilot review items — already addressed

The copilot review flagged throwError(() => error) inside tapResponse error handlers in the experiments stores as no-ops. These were already correctly fixed in this PR: the old RxJS 6 code had throwError(error) (bare, not factory) inside those handlers, and the PR correctly replaced them with this.dotHttpErrorManagerService.handle(error) + state resets. Copilot's comments reflect the intermediate state; the current code in those files is correct.

Overall

The bulk of the migration (pluck → map, switchMapTo → switchMap, throwError factory form, toPromise → lastValueFrom, flatMap → mergeMap) is mechanically correct across the ~100 files. The one real regression is the getFormIndetifier property name issue above.

Copilot

Pull request overview

Migrates core-web from RxJS 6-style/deprecated APIs to RxJS 7-compatible patterns (operators and error creation), updating both production code and test suites to remove deprecated operators like pluck, switchMapTo, and legacy throwError signatures.

Changes:

Upgraded RxJS dependency to 7.8.2 and updated lockfile accordingly.
Replaced deprecated operators/usages (pluck → map, switchMapTo → switchMap, toPromise() → lastValueFrom, throwError(value) → throwError(() => value)).
Updated a large set of unit/integration tests to use RxJS 7 error factory signatures.

Reviewed changes

Copilot reviewed 122 out of 123 changed files in this pull request and generated 11 comments.

Show a summary per file

File	Description
core-web/yarn.lock	Locks RxJS 7.x and related dependency graph updates.
core-web/package.json	Bumps `rxjs` to 7.8.2 and records Yarn package manager metadata.
core-web/libs/ui/src/lib/services/dot-browsing/dot-browsing.service.spec.ts	Updates `throwError` test usage to RxJS 7 factory form.
core-web/libs/ui/src/lib/components/dot-site/dot-site.component.spec.ts	Updates `throwError` test usage to RxJS 7 factory form.
core-web/libs/ui/src/lib/components/dot-language-selector/dot-language-selector.component.spec.ts	Updates `throwError` test usage to RxJS 7 factory form.
core-web/libs/ui/src/lib/components/dot-content-type/dot-content-type.component.spec.ts	Updates `throwError` test usage to RxJS 7 factory form.
core-web/libs/ui/src/lib/components/dot-browser-selector/store/browser.store.test.ts	Updates `throwError` test usage to RxJS 7 factory form.
core-web/libs/ui/src/lib/components/dot-asset-search/store/dot-asset-search.store.ts	Replaces internal RxJS imports with public `rxjs` exports.
core-web/libs/ui/src/lib/components/dot-ai-image-prompt/store/ai-image-prompt.store.spec.ts	Updates `throwError` test usage to RxJS 7 factory form.
core-web/libs/template-builder/src/lib/components/template-builder/template-builder.component.spec.ts	Replaces `pluck` usage with `map` in store VM assertions.
core-web/libs/template-builder/src/lib/components/template-builder/store/template-builder.store.spec.ts	Replaces `pluck` usage with `map` for VM-derived streams.
core-web/libs/portlets/edit-ema/ui/src/lib/dot-favorite-page/store/dot-favorite-page.store.ts	Updates `throwError` usage to RxJS 7 factory form.
core-web/libs/portlets/edit-ema/ui/src/lib/dot-favorite-page/store/dot-favorite-page.store.spec.ts	Updates `throwError` test usage to RxJS 7 factory form.
core-web/libs/portlets/edit-ema/ui/src/lib/dot-favorite-page/dot-favorite-page.component.spec.ts	Replaces internal RxJS imports with public `rxjs` exports.
core-web/libs/portlets/edit-ema/ui/src/lib/dot-content-compare/components/dot-content-compare-dialog/dot-content-compare-dialog.component.ts	Replaces `pluck` with `map` for event payload extraction.
core-web/libs/portlets/edit-ema/portlet/src/lib/store/features/editor/withLock.spec.ts	Updates `throwError` test usage to RxJS 7 factory form.
core-web/libs/portlets/edit-ema/portlet/src/lib/store/features/editor/save/withSave.ts	Updates `throwError` usage to RxJS 7 factory form.
core-web/libs/portlets/edit-ema/portlet/src/lib/services/dot-page-api.service.ts	Replaces `pluck` with `map` for API response extraction.
core-web/libs/portlets/edit-ema/portlet/src/lib/services/dot-action-url/dot-action-url.service.ts	Replaces `pluck` with `map` for API response extraction.
core-web/libs/portlets/edit-ema/portlet/src/lib/services/dot-action-url/dot-action-url.service.spec.ts	Updates `throwError` test usage to RxJS 7 factory form.
core-web/libs/portlets/edit-ema/portlet/src/lib/edit-ema-editor/edit-ema-editor.component.spec.ts	Updates `throwError` test usage and modernizes expectation matching.
core-web/libs/portlets/edit-ema/portlet/src/lib/edit-ema-editor/components/dot-uve-toolbar/dot-uve-toolbar.component.spec.ts	Updates `throwError` test usage to RxJS 7 factory form.
core-web/libs/portlets/edit-ema/portlet/src/lib/edit-ema-editor/components/dot-uve-palette/components/dot-uve-style-editor-form/dot-uve-style-editor-form.component.spec.ts	Updates `throwError` test usage to RxJS 7 factory form.
core-web/libs/portlets/edit-ema/portlet/src/lib/edit-ema-editor/components/dot-uve-palette/components/dot-uve-palette-list/store/store.spec.ts	Updates `throwError` test usage to RxJS 7 factory form.
core-web/libs/portlets/edit-ema/portlet/src/lib/components/dot-block-editor-sidebar/dot-block-editor-sidebar.component.spec.ts	Updates `throwError` test usage to RxJS 7 factory form.
core-web/libs/portlets/dot-usage/src/lib/dot-usage-shell/dot-usage-shell.component.spec.ts	Updates `throwError` test usage to RxJS 7 factory form.
core-web/libs/portlets/dot-tags/src/lib/dot-tags-list/store/dot-tags-list.store.spec.ts	Updates `throwError` test usage to RxJS 7 factory form.
core-web/libs/portlets/dot-tags/src/lib/dot-tags-import/dot-tags-import.component.spec.ts	Updates `throwError` test usage to RxJS 7 factory form.
core-web/libs/portlets/dot-locales/portlet/src/lib/dot-locales-list/store/dot-locales-list.store.spec.ts	Updates `throwError` test usage to RxJS 7 factory form.
core-web/libs/portlets/dot-experiments/portlet/src/lib/dot-experiments-list/store/dot-experiments-list-store.ts	Updates `throwError` usage within store effects.
core-web/libs/portlets/dot-experiments/portlet/src/lib/dot-experiments-configuration/store/dot-experiments-configuration-store.ts	Updates `throwError` usage within store effects.
core-web/libs/portlets/dot-experiments/portlet/src/lib/dot-experiments-configuration/store/dot-experiments-configuration-store.spec.ts	Updates `throwError` test usage to RxJS 7 factory form; minor formatting.
core-web/libs/portlets/dot-content-drive/portlet/src/lib/store/dot-content-drive.store.spec.ts	Updates `throwError` test usage to RxJS 7 factory form.
core-web/libs/portlets/dot-content-drive/portlet/src/lib/dot-content-drive-shell/dot-content-drive-shell.component.spec.ts	Updates `throwError` test usage to RxJS 7 factory form; minor typing adjustment.
core-web/libs/portlets/dot-content-drive/portlet/src/lib/components/dot-folder-list-context-menu/dot-folder-list-context-menu.component.ts	Replaces `toPromise()` with `lastValueFrom` for awaited HTTP observables.
core-web/libs/portlets/dot-content-drive/portlet/src/lib/components/dot-folder-list-context-menu/dot-folder-list-context-menu.component.spec.ts	Updates `throwError` test usage to RxJS 7 factory form.
core-web/libs/portlets/dot-content-drive/portlet/src/lib/components/dot-content-drive-toolbar/components/dot-content-drive-workflow-actions/dot-content-drive-workflow-actions.component.spec.ts	Updates `throwError` test usage to RxJS 7 factory form.
core-web/libs/portlets/dot-content-drive/portlet/src/lib/components/dot-content-drive-toolbar/components/dot-content-drive-content-type-field/dot-content-drive-content-type-field.component.spec.ts	Updates `throwError` test usage to RxJS 7 factory form.
core-web/libs/portlets/dot-content-drive/portlet/src/lib/components/dialogs/dot-content-drive-dialog-folder/dot-content-drive-dialog-folder.component.spec.ts	Updates `throwError` test usage to RxJS 7 factory form.
core-web/libs/portlets/dot-analytics/portlet/src/lib/dot-analytics-search/store/dot-analytics-search.store.spec.ts	Updates `throwError` test usage to RxJS 7 factory form.
core-web/libs/edit-content/src/lib/store/features/workflow/workflow.feature.spec.ts	Updates `throwError` test usage to RxJS 7 factory form.
core-web/libs/edit-content/src/lib/store/features/user/user.feature.spec.ts	Updates `throwError` test usage to RxJS 7 factory form.
core-web/libs/edit-content/src/lib/store/features/lock/lock.feature.spec.ts	Updates `throwError` test usage to RxJS 7 factory form.
core-web/libs/edit-content/src/lib/store/features/history/history.feature.spec.ts	Updates `throwError` test usage to RxJS 7 factory form.
core-web/libs/edit-content/src/lib/store/features/content/content.feature.spec.ts	Updates `throwError` test usage to RxJS 7 factory form.
core-web/libs/edit-content/src/lib/store/features/activities/activities.feature.spec.ts	Updates `throwError` test usage to RxJS 7 factory form.
core-web/libs/edit-content/src/lib/services/dot-edit-content.service.ts	Replaces `pluck` with `map` for API response extraction.
core-web/libs/edit-content/src/lib/fields/dot-edit-content-relationship-field/components/dot-select-existing-content/store/existing-content.store.spec.ts	Updates `throwError` test usage to RxJS 7 factory form.
core-web/libs/edit-content/src/lib/fields/dot-edit-content-relationship-field/components/dot-select-existing-content/store/existing-content.service.spec.ts	Updates `throwError` test usage to RxJS 7 factory form.
core-web/libs/edit-content/src/lib/fields/dot-edit-content-relationship-field/components/dot-select-existing-content/components/search/components/site-field/site-field.store.spec.ts	Updates `throwError` test usage to RxJS 7 factory form.
core-web/libs/edit-content/src/lib/fields/dot-edit-content-relationship-field/components/dot-select-existing-content/components/search/components/language-field/language-field.store.spec.ts	Updates `throwError` test usage to RxJS 7 factory form.
core-web/libs/edit-content/src/lib/fields/dot-edit-content-file-field/store/file-field.store.spec.ts	Updates `throwError` test usage to RxJS 7 factory form.
core-web/libs/edit-content/src/lib/fields/dot-edit-content-file-field/components/dot-form-import-url/store/form-import-url.store.spec.ts	Updates `throwError` test usage to RxJS 7 factory form.
core-web/libs/edit-content/src/lib/fields/dot-edit-content-file-field/components/dot-file-field-preview/dot-file-field-preview.component.spec.ts	Updates `throwError` test usage to RxJS 7 factory form.
core-web/libs/edit-content/src/lib/fields/dot-edit-content-category-field/services/categories.service.ts	Replaces `pluck` with `map` for API response extraction.
core-web/libs/edit-content-bridge/package.json	Bumps RxJS dependency to 7.8.2.
core-web/libs/dot-rules/src/lib/services/api/rule/Rule.it-spec.ts	Replaces deprecated static `Observable.*` and `flatMap` with `from/merge` + `mergeMap`.
core-web/libs/data-access/src/lib/ema-app-configuration/ema-app-configuration.service.ts	Replaces `pluck` with `map` for nested response extraction.
core-web/libs/data-access/src/lib/dot-workflows-actions/dot-workflows-actions.service.ts	Replaces `pluck` with `map` for response entity extraction.
core-web/libs/data-access/src/lib/dot-workflow/dot-workflow.service.ts	Replaces `pluck` with `map` for response entity extraction.
core-web/libs/data-access/src/lib/dot-workflow-actions-fire/dot-workflow-actions-fire.service.ts	Replaces `pluck` with `map` for response entity extraction.
core-web/libs/data-access/src/lib/dot-versionable/dot-versionable.service.ts	Replaces `pluck` with `map` for response entity extraction.
core-web/libs/data-access/src/lib/dot-upload-file/dot-upload-file.service.ts	Replaces `pluck` with `map`; updates `throwError` to factory signature.
core-web/libs/data-access/src/lib/dot-site/dot-site.service.ts	Replaces `pluck` with `map` for response entity extraction.
core-web/libs/data-access/src/lib/dot-resource-links/dot-resource-links.service.ts	Replaces `pluck` with `map` for response entity extraction.
core-web/libs/data-access/src/lib/dot-properties/dot-properties.service.ts	Replaces `pluck` with `map` for response entity/key extraction.
core-web/libs/data-access/src/lib/dot-page-workflows-actions/dot-page-workflows-actions.service.ts	Replaces `pluck` with `map` and tightens response typing.
core-web/libs/data-access/src/lib/dot-page-tools/dot-page-tools.service.ts	Replaces `pluck` with `map` for assets response extraction.
core-web/libs/data-access/src/lib/dot-page-state/dot-page-state.service.ts	Replaces `pluck` with `map` for locker message extraction.
core-web/libs/data-access/src/lib/dot-page-state/dot-page-state.service.spec.ts	Updates `throwError` test usage to RxJS 7 factory form.
core-web/libs/data-access/src/lib/dot-messages/dot-messages.service.ts	Replaces `pluck` with `map` for message entity extraction.
core-web/libs/data-access/src/lib/dot-license/dot-license.service.ts	Replaces `pluck` with `map` for nested license extraction.
core-web/libs/data-access/src/lib/dot-field/dot-field.service.ts	Replaces `pluck` with `map` for response entity extraction.
core-web/libs/data-access/src/lib/dot-experiments/dot-experiments.service.ts	Replaces `pluck` with `map` for entity/health extraction.
core-web/libs/data-access/src/lib/dot-edit-page-resolver/dot-edit-page-resolver.service.ts	Updates `throwError` to RxJS 7 factory signature for resolver error responses.
core-web/libs/data-access/src/lib/dot-edit-page-resolver/dot-edit-page-resolver.service.spec.ts	Updates `throwError` test usage to RxJS 7 factory form.
core-web/libs/data-access/src/lib/dot-copy-content/dot-copy-content.service.ts	Replaces `pluck` with `map` after `shareReplay`.
core-web/libs/data-access/src/lib/dot-contentlet/dot-contentlet.service.ts	Replaces `pluck` with indexed `map` for language-specific versions.
core-web/libs/data-access/src/lib/dot-content-type/dot-content-type.service.ts	Replaces `flatMap`/`pluck` with `mergeMap`/`map`.
core-web/libs/data-access/src/lib/dot-content-search/dot-content-search.service.ts	Replaces `pluck` with `map` for response entity extraction.
core-web/libs/data-access/src/lib/dot-analytics-search/dot-analytics-search.service.ts	Replaces `pluck` with `map` for response entity extraction.
core-web/libs/data-access/src/lib/dot-ai/dot-ai.service.ts	Updates `throwError` to RxJS 7 factory signature; replaces `pluck` with `map`.
core-web/libs/block-editor/src/lib/shared/services/suggestions/suggestions.service.ts	Replaces `pluck` with `map` for nested response extraction.
core-web/libs/block-editor/src/lib/extensions/asset-form/components/dot-upload-asset/dot-upload-asset.component.ts	Updates `throwError` to RxJS 7 factory signature.
core-web/libs/block-editor/src/lib/elements/dot-bubble-menu/components/dot-link-editor-popover/dot-link-editor-popover.component.ts	Replaces `pluck` with `map` for nested response extraction.
core-web/apps/dotcms-ui/src/stories/primeng/overlay/SharedProducts.service.ts	Replaces `toPromise()` with `lastValueFrom` in demo service.
core-web/apps/dotcms-ui/src/app/view/components/login/reset-password-component/reset-password.component.spec.ts	Updates `throwError` test usage to RxJS 7 factory form.
core-web/apps/dotcms-ui/src/app/view/components/login/main/dot-login-page.component.ts	Replaces `pluck` with `map` for login page state entity.
core-web/apps/dotcms-ui/src/app/view/components/login/forgot-password-component/forgot-password.component.spec.ts	Updates `throwError` test usage to RxJS 7 factory form.
core-web/apps/dotcms-ui/src/app/view/components/login/dot-login-component/dot-login.component.spec.ts	Updates `throwError` test usage to RxJS 7 factory form.
core-web/apps/dotcms-ui/src/app/view/components/dot-toolbar/components/dot-my-account/dot-my-account.component.spec.ts	Updates `throwError` test usage to RxJS 7 factory form.
core-web/apps/dotcms-ui/src/app/view/components/dot-device-selector/dot-device-selector.component.ts	Replaces `flatMap` with `mergeMap` for device list flattening.
core-web/apps/dotcms-ui/src/app/view/components/dot-contentlet-editor/components/dot-create-contentlet/dot-create-contentlet.component.ts	Replaces `pluck` with `map` for route data extraction.
core-web/apps/dotcms-ui/src/app/view/components/dot-add-persona-dialog/dot-add-persona-dialog.component.spec.ts	Updates `throwError` test usage to RxJS 7 factory form.
core-web/apps/dotcms-ui/src/app/view/components/_common/iframe/iframe-porlet-legacy/iframe-porlet-legacy.component.ts	Replaces `pluck` with `map` for route/param/query extraction.
core-web/apps/dotcms-ui/src/app/view/components/_common/dot-workflows-actions-selector-field/services/dot-workflows-actions-selector-field.service.spec.ts	Updates `throwError` test usage to RxJS 7 factory form.
core-web/apps/dotcms-ui/src/app/shared/interceptors/server-error.interceptor.ts	Updates `throwError` to RxJS 7 factory signature.
core-web/apps/dotcms-ui/src/app/portlets/shared/dot-content-types-listing/dot-content-types.component.ts	Replaces `pluck` with `map` for route data extraction.
core-web/apps/dotcms-ui/src/app/portlets/shared/dot-content-types-listing/dot-content-type.store.spec.ts	Updates `throwError` test usage to RxJS 7 factory form.
core-web/apps/dotcms-ui/src/app/portlets/shared/dot-content-types-edit/dot-content-types-edit.component.ts	Replaces `pluck` with `map` for delete-fields response extraction.
core-web/apps/dotcms-ui/src/app/portlets/shared/dot-content-types-edit/dot-content-types-edit.component.spec.ts	Updates `throwError` test usage to RxJS 7 factory form.
core-web/apps/dotcms-ui/src/app/portlets/shared/dot-content-types-edit/components/fields/content-type-fields-properties-form/field-properties/dot-relationships-property/dot-edit-relationship/dot-edit-relationships.component.ts	Replaces `flatMap` with `mergeMap` for relationship flattening.
core-web/apps/dotcms-ui/src/app/portlets/shared/dot-content-types-edit/components/dot-block-editor-settings/dot-block-editor-settings.component.spec.ts	Updates `throwError` test usage to RxJS 7 factory form.
core-web/apps/dotcms-ui/src/app/portlets/shared/dot-content-types-edit/components/dot-binary-settings/dot-binary-settings.component.spec.ts	Updates `throwError` test usage to RxJS 7 factory form.
core-web/apps/dotcms-ui/src/app/portlets/dot-templates/dot-template-create-edit/store/dot-template.store.spec.ts	Updates `throwError` test usage to RxJS 7 factory form.
core-web/apps/dotcms-ui/src/app/portlets/dot-templates/dot-template-create-edit/dot-template-props/dot-template-thumbnail-field/dot-template-thumbnail-field.component.ts	Updates `throwError` usage to RxJS 7 factory form.
core-web/apps/dotcms-ui/src/app/portlets/dot-templates/dot-template-create-edit/dot-template-props/dot-template-thumbnail-field/dot-template-thumbnail-field.component.spec.ts	Updates `throwError` test usage to RxJS 7 factory form.
core-web/apps/dotcms-ui/src/app/portlets/dot-pages/store/withFavorite/withFavorite.spec.ts	Updates `throwError` test usage to RxJS 7 factory form.
core-web/apps/dotcms-ui/src/app/portlets/dot-pages/store/store.spec.ts	Updates `throwError` test usage to RxJS 7 factory form.
core-web/apps/dotcms-ui/src/app/portlets/dot-pages/services/dot-page-actions.service.spec.ts	Updates `throwError` test usage to RxJS 7 factory form.
core-web/apps/dotcms-ui/src/app/portlets/dot-pages/dot-pages-store/dot-pages.store.spec.ts	Updates `throwError` test usage to RxJS 7 factory form.
core-web/apps/dotcms-ui/src/app/portlets/dot-form-builder/dot-form-builder.component.ts	Replaces `pluck` with `map` for route data extraction.
core-web/apps/dotcms-ui/src/app/portlets/dot-containers/dot-container-create/dot-container-properties/store/dot-container-properties.store.ts	Replaces `pluck` with `map` for route data extraction.
core-web/apps/dotcms-ui/src/app/portlets/dot-containers/dot-container-create/dot-container-create.component.ts	Replaces `pluck` with `map` for route data extraction.
core-web/apps/dotcms-ui/src/app/portlets/dot-containers/container-list/store/dot-container-list.store.ts	Replaces `pluck` with `map` for route data extraction.
core-web/apps/dotcms-ui/src/app/portlets/dot-apps/dot-apps-import-export-dialog/store/dot-apps-import-export-dialog.store.spec.ts	Updates `throwError` test usage to RxJS 7 factory form.
core-web/apps/dotcms-ui/src/app/portlets/dot-apps/components/dot-apps-configuration/dot-apps-configuration.component.ts	Replaces `pluck` with `map` for route data extraction.
core-web/apps/dotcms-ui/src/app/portlets/dot-apps/components/dot-apps-configuration-detail/dot-apps-configuration-detail.component.ts	Replaces `pluck` with `map` for route data extraction.
core-web/apps/dotcms-ui/src/app/app.component.spec.ts	Updates `throwError` test usage to RxJS 7 factory form.
core-web/apps/dotcms-ui/src/app/api/services/dynamic-route-initializer.service.spec.ts	Updates `throwError` test usage to RxJS 7 factory form.
core-web/apps/dotcms-ui/src/app/api/services/dot-menu.service.ts	Replaces `pluck`/`publishLast`/`refCount` with `map` + `shareReplay`.
core-web/apps/dotcdn/src/app/dotcdn.component.store.ts	Replaces `switchMapTo` with `switchMap`.
.cursor/plans/rxjs_7_migration_plan_c65e7afc.plan.md	Adds a migration plan document for the RxJS 7 upgrade work.

...s/portlet/src/lib/dot-experiments-configuration/store/dot-experiments-configuration-store.ts

...ets/dot-experiments/portlet/src/lib/dot-experiments-list/store/dot-experiments-list-store.ts

...s/portlet/src/lib/dot-experiments-configuration/store/dot-experiments-configuration-store.ts

core-web/libs/data-access/src/lib/dot-page-tools/dot-page-tools.service.ts

core-web/apps/dotcms-ui/src/app/api/services/dot-menu.service.ts

core-web/libs/portlets/edit-ema/portlet/src/lib/services/dot-page-api.service.ts

...ets/dot-experiments/portlet/src/lib/dot-experiments-list/store/dot-experiments-list-store.ts

...s/portlet/src/lib/dot-experiments-configuration/store/dot-experiments-configuration-store.ts

… type safety

…mers for improved timing control

…Page stores by utilizing dotHttpErrorManagerService

oidacra · 2026-03-30T20:14:23Z

core-web/apps/dotcms-ui/src/app/portlets/dot-pages/dot-pages-store/dot-pages.store.ts

                        filterParams,
-                        collapsedParam
+                        collapsedParam,
+                        ,


This is intentional?

oidacra · 2026-03-30T20:18:29Z

core-web/libs/data-access/src/lib/dot-experiments/dot-experiments.service.ts

                DotCMSResponseExperiment<{ healthy: HealthStatusTypes }>
            >('/api/v1/experiments/health')
-            .pipe(pluck('entity', 'health'));
+            .pipe(map((x) => x?.entity?.healthy));


This is health or healthy?

nicobytes added 2 commits March 27, 2026 11:28

chore(dependencies): update rxjs to version 7.8.2 and add packageMana…

f441834

…ger field in package.json

refactor: update RxJS operators in various components and services

ea037a4

nicobytes requested a review from Copilot March 27, 2026 16:00

nicobytes linked an issue Mar 27, 2026 that may be closed by this pull request

Upgrade RxJS from v6 to v7 #33073

Open

github-project-automation bot added this to dotCMS - Product Planning Mar 27, 2026

github-actions bot mentioned this pull request Mar 27, 2026

Upgrade RxJS from v6 to v7 #33073

Open

github-actions bot added the Area : Frontend PR changes Angular/TypeScript frontend code label Mar 27, 2026

Copilot started reviewing on behalf of nicobytes March 27, 2026 16:01 View session

Copilot AI reviewed Mar 27, 2026

View reviewed changes

claude bot added the AI: Safe To Rollback label Mar 27, 2026

nicobytes added 5 commits March 27, 2026 12:44

Merge branch 'main' into 33073-rxjs-from-v6-to-v7

4eff957

refactor: update HTTP response types in various services for improved…

c723720

… type safety

test: refactor DotCreatePageDialogComponent tests to use jest fake ti…

6e650f7

…mers for improved timing control

refactor: streamline error handling in DotExperiments and DotFavorite…

934456a

…Page stores by utilizing dotHttpErrorManagerService

Merge branch 'main' into 33073-rxjs-from-v6-to-v7

11afd40

nicobytes requested review from KevinDavilaDotCMS, adrianjm-dotCMS, hmoreras, oidacra, rjvelazco and zJaaal March 30, 2026 15:51

oidacra reviewed Mar 30, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

33073 rxjs from v6 to v7#35145

33073 rxjs from v6 to v7#35145
nicobytes wants to merge 7 commits intomainfrom
33073-rxjs-from-v6-to-v7

nicobytes commented Mar 27, 2026 •

edited

Loading

Uh oh!

claude bot commented Mar 27, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

oidacra Mar 30, 2026

Uh oh!

oidacra Mar 30, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

nicobytes commented Mar 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

claude bot commented Mar 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Review: RxJS v6 → v7 Migration

Bug: getFormIndetifier — regression in property access

Minor: shareReplay ordering in dot-menu.service.ts

Copilot review items — already addressed

Overall

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

oidacra Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

oidacra Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

nicobytes commented Mar 27, 2026 •

edited

Loading

claude bot commented Mar 27, 2026 •

edited

Loading

Bug: `getFormIndetifier` — regression in property access

Minor: `shareReplay` ordering in `dot-menu.service.ts`