Open
Conversation
Contributor
…g, null guard - Open one connection outside the loop instead of N+1 connections - Add per-row try/catch so a bad trigger doesn't abort remaining rows - Null-check getFireTimeAfter() to avoid NPE on expired cron expressions - Hoist CronTrigger and updateSql outside the loop Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Member
Author
|
FWIW, this branch already includes 1 round of fixes to appease claude before we ran out of tokens. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref: #35119
This fixes a leak that is shown 30m after whenever dotCMS starts up.