Skip to content

fix: General feedback and UI improvements for portlets#34516

Merged
zJaaal merged 11 commits intoissue-33882-primeng-updatefrom
34254-general-feedback-jal-portlets
Feb 5, 2026
Merged

fix: General feedback and UI improvements for portlets#34516
zJaaal merged 11 commits intoissue-33882-primeng-updatefrom
34254-general-feedback-jal-portlets

Conversation

@zJaaal
Copy link
Contributor

@zJaaal zJaaal commented Feb 5, 2026

Summary

This PR addresses general feedback and UI improvements across multiple portlets as part of the PrimeNG 21 migration effort. The changes focus on fixing styling issues, improving component behavior, and refining user interactions.

Components Changed

Apps Portlet

  • Configuration Detail Form: Updated form layout and field rendering
  • Import/Export Dialog: Improved dialog structure and removed unused styles
  • Apps Card: Enhanced card layout and styling

Containers Portlet

  • Code List: Fixed container code list rendering and functionality

Templates Portlet

  • Template Builder: Updated builder component layout
  • Theme Selector: Fixed theme selector styling and behavior

Rules Portlet

  • Rule Component: Improved form initialization and component behavior
  • Entry Component: Updated component structure

Key-Value Component (Shared UI)

  • Migration: Migrated to PrimeNG 21 patterns
  • Table Header Row: Updated header layout with new PrimeNG components
  • Table Row: Removed legacy styles and improved component structure
  • Styling: Refined spacing and visual consistency

Searchable Dropdown (Shared Component)

  • Template Updates: Improved dropdown rendering
  • Component Logic: Enhanced selection handling

Theme Component (Shared UI)

  • Theme Selector: Fixed styling and improved user interaction

Changes Overview

  • Fixed tabs width in templates portlet
  • Improved card and password field styles
  • Resolved form initialization issues
  • Enhanced key-value component migration to PrimeNG 21
  • Updated styling across multiple components for consistency

🤖 Generated with Claude Code

This PR fixes: #34254

This PR fixes: #34254

@semgrep-code-dotcms-test
Copy link

Legal Risk

The following dependencies were released under a license that
has been flagged by your organization for consideration.

Recommendation

While merging is not directly blocked, it's best to pause and consider what it means to use this license before continuing. If you are unsure, reach out to your security team or Semgrep admin to address this issue.

MPL-2.0

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR implements PrimeNG 21 migration improvements and UI refinements across multiple portlets, primarily focusing on the Templates portlet (addressing issue #34254). The changes modernize component patterns, improve styling consistency, and fix layout issues.

Changes:

  • Migrated key-value component from SCSS to Tailwind CSS classes and updated to use p-toggleSwitch instead of deprecated p-inputSwitch
  • Refactored Rules portlet to use computed signals instead of methods for better performance
  • Enhanced theme selector with proper PrimeNG passthrough configuration to fix overflow issues
  • Improved Apps portlet form initialization with defensive null checks and password field styling
  • Updated searchable dropdown component to use lowercase p-dataview and added null safety for event handling

Reviewed changes

Copilot reviewed 22 out of 24 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
dot-key-value-ng components (html/ts/scss/spec) Migrated to PrimeNG 21 patterns, removed SCSS in favor of Tailwind, updated to p-toggleSwitch
dot-theme.component.html Added passthrough config to fix overflow and layout issues in theme selector popover
dot-rule.component.ts/html Refactored getStatusText method to computed signals for better performance and reactivity
dot-rules.component.ts Removed excessive margin class for better layout
searchable-dropdown.component.ts/html Migrated to lowercase p-dataview, added null safety for pagination events
dot-apps-card components Fixed card height styling by moving h-full to card element
dot-apps-import-export-dialog Added form initialization improvements and defensive null checks
dot-apps-configuration-detail-form Added comprehensive form control existence checks in template
dot-template-builder.component.html Removed redundant tab styling classes to use default PrimeNG behavior

@zJaaal zJaaal marked this pull request as draft February 5, 2026 16:23
@zJaaal zJaaal marked this pull request as ready for review February 5, 2026 17:34
@zJaaal zJaaal merged commit b041473 into issue-33882-primeng-update Feb 5, 2026
6 checks passed
@zJaaal zJaaal deleted the 34254-general-feedback-jal-portlets branch February 5, 2026 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

1 participant