fix: General feedback and UI improvements for portlets#34516
Merged
zJaaal merged 11 commits intoissue-33882-primeng-updatefrom Feb 5, 2026
Merged
fix: General feedback and UI improvements for portlets#34516zJaaal merged 11 commits intoissue-33882-primeng-updatefrom
zJaaal merged 11 commits intoissue-33882-primeng-updatefrom
Conversation
Legal RiskThe following dependencies were released under a license that RecommendationWhile merging is not directly blocked, it's best to pause and consider what it means to use this license before continuing. If you are unsure, reach out to your security team or Semgrep admin to address this issue. MPL-2.0
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements PrimeNG 21 migration improvements and UI refinements across multiple portlets, primarily focusing on the Templates portlet (addressing issue #34254). The changes modernize component patterns, improve styling consistency, and fix layout issues.
Changes:
- Migrated key-value component from SCSS to Tailwind CSS classes and updated to use
p-toggleSwitchinstead of deprecatedp-inputSwitch - Refactored Rules portlet to use computed signals instead of methods for better performance
- Enhanced theme selector with proper PrimeNG passthrough configuration to fix overflow issues
- Improved Apps portlet form initialization with defensive null checks and password field styling
- Updated searchable dropdown component to use lowercase
p-dataviewand added null safety for event handling
Reviewed changes
Copilot reviewed 22 out of 24 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| dot-key-value-ng components (html/ts/scss/spec) | Migrated to PrimeNG 21 patterns, removed SCSS in favor of Tailwind, updated to p-toggleSwitch |
| dot-theme.component.html | Added passthrough config to fix overflow and layout issues in theme selector popover |
| dot-rule.component.ts/html | Refactored getStatusText method to computed signals for better performance and reactivity |
| dot-rules.component.ts | Removed excessive margin class for better layout |
| searchable-dropdown.component.ts/html | Migrated to lowercase p-dataview, added null safety for pagination events |
| dot-apps-card components | Fixed card height styling by moving h-full to card element |
| dot-apps-import-export-dialog | Added form initialization improvements and defensive null checks |
| dot-apps-configuration-detail-form | Added comprehensive form control existence checks in template |
| dot-template-builder.component.html | Removed redundant tab styling classes to use default PrimeNG behavior |
core-web/libs/ui/src/lib/components/dot-key-value-ng/dot-key-value-ng.component.html
Show resolved
Hide resolved
...app/view/components/_common/searchable-dropdown/component/searchable-dropdown.component.html
Show resolved
Hide resolved
...portlets/dot-apps/dot-apps-import-export-dialog/dot-apps-import-export-dialog.component.html
Outdated
Show resolved
Hide resolved
...ponents/dot-apps-configuration-detail-form/dot-apps-configuration-detail-form.component.html
Outdated
Show resolved
Hide resolved
...p/portlets/dot-apps/dot-apps-import-export-dialog/dot-apps-import-export-dialog.component.ts
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses general feedback and UI improvements across multiple portlets as part of the PrimeNG 21 migration effort. The changes focus on fixing styling issues, improving component behavior, and refining user interactions.
Components Changed
Apps Portlet
Containers Portlet
Templates Portlet
Rules Portlet
Key-Value Component (Shared UI)
Searchable Dropdown (Shared Component)
Theme Component (Shared UI)
Changes Overview
🤖 Generated with Claude Code
This PR fixes: #34254
This PR fixes: #34254