Skip to content

Address review feedback on chalk usage in CLI validation#34513

Closed
Copilot wants to merge 1 commit intoissue-create-app-cli-critical-bugsfrom
copilot/sub-pr-34472
Closed

Address review feedback on chalk usage in CLI validation#34513
Copilot wants to merge 1 commit intoissue-create-app-cli-critical-bugsfrom
copilot/sub-pr-34472

Conversation

Copy link
Contributor

Copilot AI commented Feb 5, 2026

Proposed Changes

No code changes required. The review comment was addressing a bot suggestion to replace console.log with console.warn for warning messages. The current implementation intentionally uses console.log with chalk for proper terminal color formatting.

The existing code in validation.ts lines 104-108:

console.log(
    chalk.yellow('⚠️  Warning: ') +
        chalk.white('Using localhost but port is not 8082 (default dotCMS port)')
);

This approach ensures consistent visual formatting in terminal output where chalk.yellow() provides the warning color, making console.warn unnecessary and potentially conflicting with the intended formatting.

Checklist

  • Tests
  • Translations
  • Security Implications Contemplated (N/A - no code changes)

Additional Info

This PR was created to address review feedback on #34472. After investigation, the feedback was clarifying the intentional design choice rather than requesting changes.

Screenshots

N/A - No code changes made


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI changed the title [WIP] Fix CLI validation bugs and improve error handling Address review feedback on chalk usage in CLI validation Feb 5, 2026
Copilot AI requested a review from fmontes February 5, 2026 13:08
@fmontes fmontes closed this Feb 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants