34323 implement api to post bundle for publishing#34481
Open
hassandotcms wants to merge 5 commits intomainfrom
Open
34323 implement api to post bundle for publishing#34481hassandotcms wants to merge 5 commits intomainfrom
hassandotcms wants to merge 5 commits intomainfrom
Conversation
…dpoint - Add PushBundleForm: request body for push bundle operation - operation (publish/expire/publishexpire) - publishDate, expireDate (ISO 8601 format) - environments (list of environment IDs) - filterKey - Add AbstractPushBundleResultView: @Value.Immutable response DTO - Add ResponseEntityPushBundleResultView: typed response wrapper
- Add parseISO8601Date(): parse ISO 8601 dates with timezone offset - Add validatePushBundleForm(): validate required fields and operation type - Add validateEnvironmentPermissions(): check user permissions on environments - Add PermissionAPI dependency to PublishingJobsHelper
…} endpoint Add endpoint to push existing bundles to environments for publishing. Supports three operations: - publish: schedule content for publishing - expire: schedule content for unpublishing - publishexpire: publish now with scheduled expiration Features: - ISO 8601 date format with timezone offset - Environment permission validation - Filter lookup with default fallback (matches existing UI behavior) - Returns actual valid environment IDs (not echoed request)
Add 18 test cases covering: - Success cases: publish, expire, publishexpire operations - Validation: missing/invalid operation, dates, environments, filterKey - Edge cases: case-insensitive operations, multiple environments - Error cases: bundle not found, environment not found, invalid date format - Default filter fallback behavior
- PushBundleForm: extend Validated, move validation to checkValid() - PublishingResource: add @RequestBody annotation for Swagger docs - PublishingResource: call form.checkValid() instead of helper - PublishingJobsHelper: remove validatePushBundleForm (moved to form)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
POST /v1/publishing/push/{bundleId}endpoint to queue bundles for publishingChecklist
Additional Info
** any additional useful context or info **
Screenshots
This PR fixes: #34323