Fortran dockerized #114
Open
Fortran dockerized #114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I had to rename the fortran directory due to docker compilation issues. Also the fortran code only reads up to the first name? (thus the test results in ' Reinier' instead of the expected 'Reinier Kip')
Contributor
|
I'll ask @DRvanR |
Contributor
Author
|
thnx... its probably something with the READ command... but err... my fortran Skilzz are... "lacking" ;) |
Contributor
|
@DRvanR told me he would look into it but it might take some time so let's just leave this one for now |
Contributor
Author
|
Willdo |
Contributor
Author
|
Does this pull include the fix ? |
Contributor
|
@fruitl00p I've reopened this PR since it should to dockerize this one now right? |
Contributor
Author
|
I'll take another look at the current state, the current PR doesnt include the fix yet, will update! |
Contributor
Author
|
@lucasvanlierop could you try a rebuild on Travis? It worked locally with the updates from master merged, thus i would expect Travis to light up green too? |
Contributor
|
Retry in progress |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to rename the fortran directory due to docker compilation issues.
Also the fortran code only reads up to the first name?
(thus the test results in ' Reinier' instead of the expected 'Reinier Kip')