fix: preserve file mtime after atomic rewrite#48
Closed
leno23 wants to merge 1 commit into
Closed
Conversation
Call os.Chtimes on the temp file before rename so Make-style dependency tracking and watchers see a stable modification time. Fixes dolph#23
leno23
force-pushed
the
fix/preserve-mtime-23
branch
from
3e6862a to
4bec93f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
os.Chtimeson the temp file beforeRenameso modification time matches the original fileFixes #23
Test plan
go test ./...