Skip to content

Rework MTX#136

Open
vabold wants to merge 1 commit intodoldecomp:masterfrom
vabold:mtx
Open

Rework MTX#136
vabold wants to merge 1 commit intodoldecomp:masterfrom
vabold:mtx

Conversation

@vabold
Copy link
Copy Markdown
Contributor

@vabold vabold commented Apr 29, 2026

No description provided.

@vabold vabold force-pushed the mtx branch 2 times, most recently from 597a26b to 4bac830 Compare April 29, 2026 00:22
Comment thread include/revolution/MTX/internal/mtx44extAssert.h Outdated
Comment thread include/revolution/MTX/GeoTypes.h Outdated
Comment thread include/revolution/MTX/internal/mtxAssert.h Outdated
Comment thread include/revolution/MTX/mtx.h Outdated
Comment thread include/revolution/MTX/mtx44ext.h Outdated
Comment thread src/revolution/MTX/vec.c Outdated
Comment thread src/revolution/MTX/vec.c Outdated
Comment thread src/revolution/MTX/vec.c Outdated
Comment thread src/revolution/MTX/vec.c
Comment thread src/revolution/MTX/vec.c Outdated
@decomp-dev
Copy link
Copy Markdown

decomp-dev Bot commented Apr 29, 2026

Report for RSPE01_01 (167f5f6 - a39cd06)

📈 Matched code: 33.21% (+0.09%, +3176 bytes)
📈 Linked code: 27.55% (+0.09%, +3176 bytes)
📉 Matched data: 37.51% (-0.00%, -16 bytes)
📈 Linked data: 53.93% (+0.00%, +40 bytes)

✅ 21 new matches
Unit Item Bytes Before After
main/revolution/MTX/mtx PSMTXConcatArray +408 0.00% 100.00%
main/revolution/MTX/mtx C_MTXLookAt +372 0.00% 100.00%
main/revolution/MTX/mtx PSMTXInverse +248 0.00% 100.00%
main/revolution/MTX/mtx C_MTXLightPerspective +248 0.00% 100.00%
main/revolution/MTX/mtx PSMTXConcat +204 0.00% 100.00%
main/revolution/MTX/mtx PSMTXInvXpose +200 0.00% 100.00%
main/revolution/MTX/mtx PSMTXRotTrig +176 0.00% 100.00%
main/revolution/MTX/mtx __PSMTXRotAxisRadInternal +176 0.00% 100.00%
main/revolution/MTX/mtx PSMTXQuat +164 0.00% 100.00%
main/revolution/MTX/mtx C_MTXLightFrustum +164 0.00% 100.00%
main/revolution/MTX/mtx C_MTXLightOrtho +136 0.00% 100.00%
main/revolution/MTX/mtx PSMTXRotRad +124 0.00% 100.00%
main/revolution/MTX/mtx PSMTXRotAxisRad +124 0.00% 100.00%
main/revolution/MTX/mtx PSMTXScaleApply +88 0.00% 100.00%
main/revolution/MTX/mtx PSMTXTranspose +80 0.00% 100.00%
main/revolution/MTX/mtx PSMTXTransApply +76 0.00% 100.00%
main/revolution/MTX/mtx PSMTXCopy +52 0.00% 100.00%
main/revolution/MTX/mtx PSMTXTrans +52 0.00% 100.00%
main/revolution/MTX/mtx PSMTXIdentity +44 0.00% 100.00%
main/revolution/MTX/mtx PSMTXScale +40 0.00% 100.00%
main/revolution/MTX/mtx .sdata +8 0.00% 100.00%
🥀 1 broken match
Unit Item Bytes Before After
main/egg/math/eggMatrix extabindex -5 100.00% 80.00%
📈 1 improvement in an unmatched item
Unit Item Bytes Before After
main/revolution/MTX/mtx .sdata2 +28 0.00% 87.50%

Co-Authored-By: Kiwi <49212064+kiwi515@users.noreply.github.com>
@vabold
Copy link
Copy Markdown
Contributor Author

vabold commented May 10, 2026

I moved away from turning off clang-format in favor of something more reinforced. I couldn't fix the ASM macro or get good bracket behavior for the normal keyword, so unfortunately there's no validation there. There are three exceptions I had to make:

  • Two of them are loading @ha and @l, which clang-format wanted to introduce whitespace (e.g. Unit01 @ha).
  • One of them is a clrlwi. instruction, which clang-format wanted to remove whitespace from (e.g. clrlwi.r7).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants