Open
Conversation
removed old compatibility checks (auto) reformatted the code used guardian pattern to reduce complexity removed unneeded line feeds
(auto) reformatted removed unneeded line feeds
(auto) reformatted guardian pattern
removed old compatibility checks (auto) reformatted droped line feeds
guardian pattern dropped old compatibility (auto) reformatted
(auto) reformatted guardian pattern
removed old compability (auto) reformatting guardian
mostly (auto) reformatting The render method is quite long and complex and proabably should be split up later
(auto) reformatting PSR-2 renaming I started on cleaning up the instruction handling methods, but left most of them as is. This needs a more detail oriented refactoring. The passing of an instruction array that is modified by reference is not ideal. Methods still need type hints and parameter doc blocks.
(auto) reformatting PSR-2 name changes
Klap-in
reviewed
Jul 4, 2025
Member
Klap-in
left a comment
Klap-in
left a comment
There was a problem hiding this comment.
Looks logical from the diff. Not tested further. Some minor notes.
Instead the debug logger is used.
Member
|
Other plugins that needs a fix for this:
(Results from codesearch with 2 year old indexation) First thought https://www.dokuwiki.org/plugin:mediasyntax was also using the include plugin, but it copied quite a bit. So we could give a notice, such that it can keep inline eventually. |
Member
Author
|
@Klap-in I added support for those three methods via a __call() method. Haven't tested this though. |
Member
|
With the updated index I found also ‘tagfilter’ uses this helper, but the used methods are already covered. Thanks, fine for me! I have not yet an opportunity to test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes most of the code style issues. PHP Code Sniffer and Rector have been applied file by file, so it's easier to review individual commits than everything at once.
This mostly addresses the obvious style issues but does not refactor the code (except for some smaller things I noticed while going through the code). Especially helper and action would need some more love (and doc blocks).
Note: for PSR-2 compatibility I had to rename a whole bunch of methods. Theoretically only the getFlags() method is supposed to be used from outside as it is the only one returned in getMethods, but I doubt that is the case. This branch should be checked at least with the blog plugin before merging.