Skip to content

Replaces reload prompts with quit for asset changes #290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MiguVT wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Replaces reload prompts with quit for asset changes #290

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ _Zero Two's Not Just A Cutie. ;)_

- Added the ability to control the position & size of the sticker using the `doki.sticker.css` configruation property.
- Fixed artifacted background images on the extension list tree & settings UI selected config (be sure to re-install your wallpaper for this to take effect).
- Restored asset installation on code-server (please be sure to clear caches and hard reload!)
- Restored asset installation on code-server (please be sure to clear caches and hard restart!)
Copy link

Copilot AI Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

“hard restart” is not a commonly understood action for code-server/web usage (where “hard reload”/cache-busting refresh is the typical instruction). This wording may make the guidance harder to follow; consider reverting to “hard reload” here or clarifying what the user should actually do (browser hard refresh vs restarting a server process).

Suggested change
- Restored asset installation on code-server (please be sure to clear caches and hard restart!)
- Restored asset installation on code-server (please be sure to clear caches and perform a hard reload of VS Code in your browser!)

Copilot uses AI. Check for mistakes.
- Added Remote Development Server/SSH connection asset installation help instructions.

# 84.2-1.2.1 [Small Dart Enhancement]
Expand Down
35 changes: 21 additions & 14 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
Steps demonstrated:
1. Choose Ryuko's Color Theme
1. Enable Ryuko's wallpaper
1. Reload/Restart VSCode
1. Restart VSCode
1. Demonstrate glass pane feature

## Screen Samples!
Expand Down Expand Up @@ -79,21 +79,28 @@ You can choose themes based on characters from these various Anime, Manga, or Vi

# Documentation

- [Theme Preview](#theme-preview)
- [Feature Preview](#feature-preview)
- [Screen Samples!](#screen-samples)
- [Complete Theme Album.](#complete-theme-album)
- [About!](#about)
- [Documentation](#documentation)
- [Configuration](#configuration)
- [Background Images](#background-images)
- [Hide VSCode Watermark](#hide-watermark)
- [Stickers](#sticker)
- [Custom Assets](#custom-assets)
- [Asset Restoration](#asset-restoration)
- [Suggestive Content](#suggestive-content)
- [Asset Removal](#remove-assets)
- [Show Changelog](#show-changelog)
- [Background Images](#background-images)
- [Settings](#settings)
- [Hide Watermark](#hide-watermark)
- [Stickers](#stickers)
- [Custom Assets](#custom-assets)
- [Asset Restoration](#asset-restoration)
- [Suggestive Content](#suggestive-content)
- [Remove Assets](#remove-assets)
- [Show Changelog](#show-changelog)
- [Miscellaneous](#miscellaneous)
- [Contributing](#contributing)
- [Theme Requests](#theme-requests)
- [Helping the community](#enjoying-the-plugin)
- [Feature Requests](#contributions)
- [More Doki Theme!](#even-more-doki-theme)
- [Contributing](#contributing)
- [Theme Requests](#theme-requests)
- [Enjoying the plugin?](#enjoying-the-plugin)
- [Contributions?](#contributions)
- [Even more Doki-Theme!](#even-more-doki-theme)

# Configuration

Expand Down
12 changes: 6 additions & 6 deletions src/ThemeManager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ export const ACTIVE_THEME = "doki.theme.active";
export const ACTIVE_STICKER = "doki.sticker.active";

const FIRST_TIME_STICKER_INSTALL = "doki.sticker.first.install";
export const handleInstallMessage = `Quick reload to see changes, please restart VSCode to remove the Unsupported warning.`
export const handleInstallMessage = `Restart to see changes, please restart VSCode to remove the Unsupported warning.`
Copy link

Copilot AI Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

handleInstallMessage is user-facing and now reads “Restart to see changes, please restart VSCode…”. This is both redundant and ambiguous about what to restart, and it no longer matches the notification action label (“Quit”). Consider rewriting to a single, consistent instruction (e.g., explicitly “Quit and re-open VSCode …”) and reusing the same wording as the action button.

Suggested change
export const handleInstallMessage = `Restart to see changes, please restart VSCode to remove the Unsupported warning.`
export const handleInstallMessage = `Quit and re-open VS Code to apply changes and remove the Unsupported warning.`;

Copilot uses AI. Check for mistakes.

const createCulturedInstall = (themeId: string): string =>
`doki.cultured.${themeId}`;
Expand Down Expand Up @@ -205,7 +205,7 @@ export function activateHideWatermark(
);
}

const quickReloadAction = "Quickly Reload Window";
const QuitAction = "Quit";
Copy link

Copilot AI Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QuitAction is a file-level constant but uses PascalCase, whereas the previous quickReloadAction (and other non-type constants in this file) use camelCase / uppercase-constant styles. Rename to a consistent constant style (e.g., quitAction / quitActionTitle or QUIT_ACTION).

Suggested change
const QuitAction = "Quit";
const quitAction = "Quit";

Copilot uses AI. Check for mistakes.

export function activateThemeAsset(
dokiTheme: DokiTheme,
Expand Down Expand Up @@ -259,11 +259,11 @@ export function showInstallNotification(message: string) {
vscode.window
.showInformationMessage(
message,
{ title: quickReloadAction }
{ title: QuitAction }
)
.then((item) => {
if (item) {
vscode.commands.executeCommand("workbench.action.reloadWindow");
vscode.commands.executeCommand("workbench.action.quit");
}
});
}
Expand All @@ -287,11 +287,11 @@ export function uninstallImages(context: vscode.ExtensionContext) {
vscode.window
.showInformationMessage(
`Removed All Images. ${handleInstallMessage}`,
{ title: quickReloadAction }
{ title: QuitAction }
)
.then((item) => {
if (item) {
vscode.commands.executeCommand("workbench.action.reloadWindow");
vscode.commands.executeCommand("workbench.action.quit");
}
Comment on lines 287 to 295
Copy link

Copilot AI Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same concern as the install flow: invoking workbench.action.quit from the uninstall notification may not work in web-based hosts (code-server), leaving users without an effective one-click path. Consider the same Desktop/Web guard + fallback here as well.

Copilot uses AI. Check for mistakes.
});
} else if (stickersRemoved === InstallStatus.FAILURE) {
Expand Down
2 changes: 1 addition & 1 deletion src/WelcomeService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ export function attemptToGreetUser(context: vscode.ExtensionContext) {
<ol>
<li>Choose Color Theme</li>
<li>Enable Theme's Stickers</li>
<li>Reload/Restart VSCode</li>
<li>Restart VSCode</li>
<li>Code!</li>
</ol>
</div>
Expand Down
Loading