Skip to content

Possibility to tune disqusIdentifier #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
varya wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Possibility to tune disqusIdentifier #23

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b34ee76
Possibility to tune disqusIdentifier
varya May 25, 2014
9905b6e
Check if undefined (empty in also possible)
varya May 25, 2014
e867b5a
Correct syntax of coffee
varya May 25, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/services.plugin.coffee
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,7 +354,10 @@ module.exports = (BasePlugin) ->
return '' unless disqusShortname
disqusDeveloper = if 'production' in @getEnvironments() then '0' else '1'
pageUrl = @getPageUrl()
disqusIdentifier = @document.slug
if @document.disqusIdentifier isnt undefined
Copy link
Member

@balupton balupton Apr 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be if @document.disqusIdentifier?

disqusIdentifier = @document.disqusIdentifier
else
disqusIdentifier = @document.slug
disqusTitle = @document.title or @document.name

# Return
Expand Down