Fixed buttons settings issue [#21] by making settings more specific. #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Looks pretty good... If we update the tests, it should be good to go. |
Author
|
Hi @RobLoach, I'm on vacation until next week. Will update tests then and resubmit PR. |
Member
|
Hey @inspired-io, thanks for this awesome PR. Wanted to follow up on it with you. Hope you had an awesome vacation 😉 . |
balupton
reviewed
Apr 17, 2017
Member
|
I have become too preoccupied by other things to review, merge, and release this PR. However, you should have received an invite a while ago to join the DocPad Extras Team, which will give you write access to this repository, so you can merge in the PR. For an orientation, or if you need any assistance following the semi-automatic release process from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I changed
buttonstosocialButtonsand addedserviceBadges.Original issue here: #21