Open
Conversation
Contributor
|
✅ DCO Check Passed Thanks @attilaolah, all your commits are properly signed off. 🎉 |
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
This comment was marked as outdated.
This comment was marked as outdated.
This change fixes a bizarre build failure that happens when trying to
build docling-parse with system cxxopts that define `CXXOPTS_USE_UNICODE`.
The error causes implicit conversion from boolean types to fail, causing
errors like this:
```
In file included from /build/docling_parse-5.7.0/src/parse.h:44,
from /build/docling_parse-5.7.0/app/parse_fonts.cpp:17:
/build/docling_parse-5.7.0/src/parse/config.h: In member function ‘nlohmann::json_abi_v3_12_0::json pdflib::decode_config::to_json() const’:
/build/docling_parse-5.7.0/src/parse/config.h:60:58: error: no matching function for call to ‘nlohmann::json_abi_v3_12_0::basic_json<>::basic_json(const bool&)’
60 | j["do_sanitization"] = nlohmann::json(do_sanitization);
| ^
```
Signed-off-by: Attila Oláh <attila@dorn.haus>
Author
|
python3.14-docling-parse-5.7.0.drv.log Here are the full build logs with the original failure, without this patch applied. With the patch applied, the build passes. |
attilaolah
added a commit
to attilaolah/citations
that referenced
this pull request
Apr 3, 2026
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an attempt at fixing the issue described in #184.
This PR updates the
#includeorder insrc/parse.hto so that<nlohmann/json.hpp>would come before<cxxopts.hpp>, resolving a build failure when-DDCXXOPTS_USE_UNICODEis defined by the cxxopts pkg-config script.I'm not 100% sure this is the "correct" way to fix the underlying root cause, but it does resolve the issue described in the original pull request and makes docling-parse compile both with and without
CXXOPTS_USE_UNICODE.To avoid regressions, it would be nice to have a CI step that builds with
-DCXXOPTS_USE_UNICODE.