fix: Remove Extra Space Before and After Group Items

[RamanaMenda]

Removing extra space before and after group items to resolve the issue raised in #2745

Resolves #371
Resolves docling-project/docling#2745

[github-actions]

✅ DCO Check Passed

Thanks @RamanaMenda, all your commits are properly signed off. 🎉

[dosubot]

Related Documentation

Checked 7 published document(s) in 1 knowledge base(s). No updates required.

^{How did I do? Any feedback?}  

[mergify]

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🔴 Require two reviewer for test updates

This rule is failing.

When test data is updated, we require two reviewers

• #approved-reviews-by >= 2

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

• title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?(!)?:

[RamanaMenda]

#371

[ceberam]

@RamanaMenda thanks for suggesting a fix for this issue
Please, make sure to resolve all the code checks before pushing new commits. I strongly recommend installing pre-commit in your local repository. It will run the code checks every time you execute git commit. Simply type uv run pre-commit install on your local repository.
In addition, keep in mind that fixing the serialization in docling-core will have an impact on docling library. Some backend parsers may trim trailing blanks in formatted text and, after this PR, the serialization may lead to missing blank space between words. In addition, some ground-truth files in the tests folder contain the (wrong) extra spaces and will need to be updated to ensure that the regression tests pass.
Therefore, I see the following pipeline to fix this issue:

1. Fix this issue of extra spaces in docling-core and submit a PR.
2. Get the PR approved, merged, and published in a new release of docling-core.
3. Fix backend parsers and ground truth files in docling to ensure that necessary blank spaces are not removed.
4. Pin the new release version of docling-core in docling's pyproject.toml file.
5. Update the uv.lock file (e.g., with uv lock --upgrade-package docling-core).
6. Ensure all tests pass in docling with the new release of docling-core.
7. Submit a PR in docling project with the changes above.

[ceberam]

@RamanaMenda just a quick check if you need support on this PR (or part of it, as described in my last message).
A first step would be to rebase to the latest version in main and resolve the existing conflicts.

[wanadzhar913]

Hi there! I'd love to pick up where you left off @RamanaMenda if that's okay. @ceberam

[RamanaMenda]

@wanadzhar913 Sure, That would be nice.

[ceberam]

Hi there! I'd love to pick up where you left off @RamanaMenda if that's okay. @ceberam

Thanks @wanadzhar913 for following up on this.
Please, keep in mind my comment on the change workflow here #458 (comment)
Also, please drop a message in the conversation of the issue #371 and docling-project/docling#2745 showing the interest in resolving them, since this will technically allow me to add you as Assignee

[wanadzhar913]

Hi there! I'd love to pick up where you left off @RamanaMenda if that's okay. @ceberam

Thanks @wanadzhar913 for following up on this. Please, keep in mind my comment on the change workflow here #458 (comment) Also, please drop a message in the conversation of the issue #371 and docling-project/docling#2745 showing the interest in resolving them, since this will technically allow me to add you as Assignee

Done!

I've rebased and resolved all the merge conflicts.

However, some commits from @RamanaMenda will need to be signed off again on my branch. Would love to maintain your original commits so can I trouble you to run the below?

git remote add pr594 https://github.com/wanadzhar913/docling-core.git
git fetch pr594
git checkout -b bugfix/2745_ExtraSpaceBeforeAndAfterGroupItems pr594/bugfix/2745_ExtraSpaceBeforeAndAfterGroupItems
git commit --allow-empty -s -m "DCO Remediation Commit for Venkata Ramana Menda <mendavramana.jnv@gmail.com>

I, Venkata Ramana Menda <mendavramana.jnv@gmail.com>, hereby add my Signed-off-by to this commit: 08049ee3806ae7896a92a6a255af3958bdfdaf5f"
git push pr594 --force-with-lease

First time doing this (taking over someone else's prior branch). Should I just create a new branch? @ceberam

[mergify]

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🔴 Require two reviewer for test updates

Waiting for:

• #approved-reviews-by >= 2

This rule is failing.

When test data is updated, we require two reviewers

• #approved-reviews-by >= 2

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

• title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?(!)?:

[wanadzhar913]

Sorry @RamanaMenda , could you push the signed commits to my branch #594? I've added you as a collaborator. Thanks so much!

Alternatively, I'd also be happy to push to your repo if you can add me as a collaborator.

[wanadzhar913]

Last try @RamanaMenda. Could you try something like this? Sorry! Should be 5 commands.

git remote add pr594 https://github.com/wanadzhar913/docling-core.git

git fetch pr594

git checkout -b bugfix-v2/2745_ExtraSpaceBeforeAndAfterGroupItems pr594/bugfix/2745_ExtraSpaceBeforeAndAfterGroupItems

# signature
git commit --allow-empty -s -m "DCO Remediation Commit for Venkata Ramana Menda <mendavramana.jnv@gmail.com>

I, Venkata Ramana Menda <mendavramana.jnv@gmail.com>, hereby add my Signed-off-by to this commit: 08049ee3806ae7896a92a6a255af3958bdfdaf5f"

# push with lease
git push pr594 --force-with-lease

[RamanaMenda]

@wanadzhar913 I have just added sign-off to my commits. Please check again.

[wanadzhar913]

@wanadzhar913 I have just added sign-off to my commits. Please check again.

can you sign off commits to my repo? https://github.com/wanadzhar913/docling-core/tree/bugfix/2745_ExtraSpaceBeforeAndAfterGroupItems @RamanaMenda