Skip to content

Conversation

@svonworl
Copy link
Contributor

@svonworl svonworl commented Apr 4, 2025

Description
Add 1.17.0 to list of migrations per this comment dockstore/dockstore#6089 (review)

Long term, one wonders if we could somehow use the embedded list of migrations (https://github.com/dockstore/dockstore/blob/fbcba80140b9d13d3ec251283ecc823373ec0f3b/dockstore-integration-testing/src/test/java/io/dockstore/common/CommonTestUtilities.java#L88) to eliminate the need to change this on every release. Maybe the webservice could spit them out if invoked the right way. Such a change would allow me to simplify some of my db loading scripts, too.

Review Instructions
Confirm that qa deploys correctly.

Issue
https://ucsc-cgl.atlassian.net/browse/SEAB-6978

Please make sure that you've checked the following before submitting your pull request. Thanks!

  • Ensure that the PR targets the correct branch. Check the milestone or fix version of the ticket.

@svonworl svonworl self-assigned this Apr 4, 2025
@kathy-t
Copy link
Contributor

kathy-t commented Apr 7, 2025

Long term, one wonders if we could somehow use the embedded list of migrations (https://github.com/dockstore/dockstore/blob/fbcba80140b9d13d3ec251283ecc823373ec0f3b/dockstore-integration-testing/src/test/java/io/dockstore/common/CommonTestUtilities.java#L88) to eliminate the need to change this on every release. Maybe the webservice could spit them out if invoked the right way. Such a change would allow me to simplify some of my db loading scripts, too.

Agreed that would be nice since the UI also runs DB migrations for the tests as well https://github.com/dockstore/dockstore-ui2/blob/76eb6450ed3aea9d91a27a4373ae9e5b213e524b/scripts/run-webservice-script.sh#L23

@denis-yuen
Copy link
Member

Long term, one wonders if we could somehow use the embedded list of migrations (https://github.com/dockstore/dockstore/blob/fbcba80140b9d13d3ec251283ecc823373ec0f3b/dockstore-integration-testing/src/test/java/io/dockstore/common/CommonTestUtilities.java#L88) to eliminate the need to change this on every release. Maybe the webservice could spit them out if invoked the right way. Such a change would allow me to simplify some of my db loading scripts, too.

Would be nice. You may not even necessarily need a live webservice.
We could output and save something automatically like the openapi yaml output and use it elsewhere.

@svonworl svonworl merged commit a328a6a into develop Apr 7, 2025
5 checks passed
@svonworl svonworl deleted the feature/seab-6978/add-1-17-migration branch April 7, 2025 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants