Add MessageDispatcher class that queues messages when WebView is unavailable#451
Open
maycon-mello wants to merge 9 commits intomasterfrom
Open
Add MessageDispatcher class that queues messages when WebView is unavailable#451maycon-mello wants to merge 9 commits intomasterfrom
maycon-mello wants to merge 9 commits intomasterfrom
Conversation
integration-tests/verification-flow/bbs-plus-revocation.test.ts
Outdated
Show resolved
Hide resolved
| return await credentialProvider.addCredential(credential); | ||
| } catch (err) { | ||
| if (!err.message?.includes('already exists')) throw err; | ||
| } |
Contributor
There was a problem hiding this comment.
do we want that debug log still if the credential already exists? Or do you think it's okay to let that be silent?
| this._send(webView, type, body); | ||
| this._send(webView, type, body); | ||
| } catch (err) { | ||
| console.warn('Failed to process queued message, discarding:', err.message); |
Contributor
There was a problem hiding this comment.
at some point we may need to make this smarter to check for errors that might be transient which would allow the message to be processed successfully in the future
we could also look at some of the queuing patterns around dead letter queues which might allow us to try to reprocess messages in the future if meaningful changes occur that would allow it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.