add modelfile support to docker model package

[areebahmeddd]

changes

completes #628

• added --file / -f flag to docker model package to load and apply a modelfile

closes #613

[gemini-code-assist]

Code Review

This pull request introduces support for Modelfile in the package command via a new --file flag, allowing users to define model sources and parameters in a configuration file. The review feedback identifies critical improvements for the parser to correctly handle file paths with spaces or quotes and suggests ignoring unknown instructions to maintain compatibility with standard Modelfiles. Additionally, the feedback recommends refining error messages to accurately reflect the new flag and improve user empathy.

[areebahmeddd]

the command is docker model package --file ./Modelfile, not a new docker model create subcommand to match the docker build -f Dockerfile convention

[ericcurtin]

@areebahmeddd thanks and nice work!

Two things, I think this should be "docker model build" or "docker model create", it's what people are used to from docker and ollama and it makes things simpler. Also, Ollama-type models are generally out of scope for this projects as they are not standards compliant (although we do have an Ollama-compatible API). I would like to see if there are plans to define a standard with the ModelPack folk before we proceed:

modelpack/model-spec#208

[areebahmeddd]

Two things, I think this should be "docker model build" or "docker model create"

sure, i’ll update it post-discussion in the modelpack issue 🙂

Also, Ollama-type models are generally out of scope for this projects as they are not standards compliant (although we do have an Ollama-compatible API)

interesting, i just read about modelpack and its spec. ollama’s modelfile seems to not follow since it uses its own binary blob format. i agree to wait for a definitive plan from the modelpack team