docs(guides): add two testcontainers intro guides (go and python)#24450
Open
mdelapenya wants to merge 7 commits intodocker:mainfrom
Open
docs(guides): add two testcontainers intro guides (go and python)#24450mdelapenya wants to merge 7 commits intodocker:mainfrom
mdelapenya wants to merge 7 commits intodocker:mainfrom
Conversation
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Member
Author
|
Regarding the bot's comments about Go 1.25+: Go 1.25 is the correct minimum version. testcontainers-go v0.41.0 specifies The bot's knowledge cutoff predates the Go 1.25 release. |
Member
Author
|
/review |
![docker-agent[bot]](https://avatars.githubusercontent.com/in/2787757?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Assessment: 🟢 APPROVE
This PR adds two comprehensive Testcontainers getting-started guides (Go and Python) migrated from testcontainers.com. The documentation is well-structured, follows Docker style guidelines, and includes all necessary supporting infrastructure.
Strengths:
- ✅ All front matter complete with required fields (title, description, keywords)
- ✅ No AI-isms, hedge words, or marketing language detected
- ✅ Code examples follow state-show-explain pattern
- ✅ Appropriate use of callouts (NOTE, TIP)
- ✅ Proper console code blocks with $ prompts
- ✅ Clear, factual explanations without passive voice
- ✅ Vale vocabulary updated for technical terms (pgx, psycopg, pytest)
- ✅ New
testing-with-dockertag added correctly - ✅ Manual page updated with guide links
No issues found - This is high-quality documentation ready to merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Migrate the first two Testcontainers getting-started guides from testcontainers.com/guides into the Docker docs site:
postgres.Run(),CleanupContainer,BasicWaitStrategies()).get_exposed_port()returningint).Each guide appears as its own entry in the
/guides/listing with proper language and tag filters (testing-with-docker). Chapters render with stepper navigation in the sidebar.Also adds:
testing-with-dockertag todata/tags.yaml.claude/skills/testcontainers-guides-migrator/SKILL.md) that documents the repeatable migration process for the remaining 19 guidescontent/manuals/testcontainers.mdto the new guidespgx,Micronaut,psycopg,pytestAll guide code was compiled and tests verified passing in containers with Docker socket mounted.
Related issues or tickets
No related issues found.
Reviews