Fix issue #24010: warn about containerd separate storage path#24447
Open
Fix issue #24010: warn about containerd separate storage path#24447
Conversation
Assisted-By: docker-agent
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
github-actions
bot
added
area/engine
![docker-agent[bot]](https://avatars.githubusercontent.com/in/2787757?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Assessment: 🟡 NEEDS ATTENTION
This PR adds a valuable warning about containerd using a separate storage path from the Docker data directory. The content addresses a real user issue (filling root partitions when custom data directories are configured).
Issues found:
- 1 style guide violation (bold used for emphasis)
- 1 maintainability concern (external link stability)
- Remove bold formatting from 'not' (bold should only be used for UI elements) - Update containerd docs link from main branch to stable v2.2.2 release Assisted-By: docker-agent
Contributor
Author
|
Thank you for the feedback on both the style violation and link stability concern. You're right on both counts. I've made the following changes:
The warning now follows our documentation standards while maintaining a reliable reference. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds warning about containerd using a separate storage path from the Docker data directory.
Changes:
This prevents users from unexpectedly filling their root partition when they assumed their custom data directory configuration would apply to containerd.
Fixes #24010