Fix issue #24286: document admin-settings.json sign-in enforcement#24444
Open
Fix issue #24286: document admin-settings.json sign-in enforcement#24444
Conversation
Assisted-By: docker-agent
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
![docker-agent[bot]](https://avatars.githubusercontent.com/in/2787757?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Assessment: 🟢 APPROVE
This PR successfully addresses issue #24286 by documenting that the presence of admin-settings.json enforces sign-in on Docker Desktop (behavior since version 4.29).
Key changes:
- Added an IMPORTANT callout in the Prerequisites section explaining the sign-in enforcement behavior
- Clarifies this is intended for business features requiring authentication
- Includes formatting cleanup (consistent indentation, whitespace standardization in JSON examples, table alignment)
Documentation quality:
- The new callout is appropriately placed and uses direct, factual language
- Follows Docker's style guide (no hedge words, no meta-commentary)
- Provides clear context for users who may be confused about sign-in requirements
No issues found. The changes improve documentation clarity and address user confusion.
Change 'Auto-Config' to 'Auto-config' in PAC descriptions to fix Vale style violations at lines 323 and 331. Assisted-By: docker-agent
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documents that the presence of admin-settings.json file enforces sign-in on Docker Desktop.
Changes:
This addresses user confusion about why Docker Desktop requires sign-in after adding the admin-settings.json file.
Fixes #24286