-
Notifications
You must be signed in to change notification settings - Fork 8.2k
hub: add namespace access control #23949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Hi @craig-osterhout, shouldn't we avoid to use our names/ids and stage test repos in the examples that we give in docs ? What's the general guidance here ? |
|
@craig-osterhout can you update the reviewer to me? |
ae7452d to
50bf875
Compare
Signed-off-by: Craig Osterhout <craig.osterhout@docker.com>
dca8c32 to
ac49898
Compare
jtwils17
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a few points of clarification
| subscription: [Business] | ||
| for: Administrators | ||
| Disable public repositories: | ||
| subscription: [Team, Business] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only Business for both features
| | Edit and delete publisher repository logos | ❌ | ✅ | ✅ | | ||
| | Observe content engagement as a publisher | ❌ | ❌ | ✅ | | ||
| | Create public and private repositories | ❌ | ✅ | ✅ | | ||
| | Disable public repositories | ❌ | ✅ | ✅ | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only Business
| You can configure the following default privacy settings for all repositories in | ||
| a namespace: | ||
|
|
||
| - [Configure disable public repositories](#configure-disable-public-repositories): Prevent |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we exclude "configure" and just make it "Disable creation of public repos"?
|
|
||
| Organization owners and editors can prevent creating public repositories within | ||
| organization namespaces. You cannot configure this setting for personal account | ||
| namespaces. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a sentence or callout like we have in the UI that enabling this feature does not affect existing repos? Ie if public repos already exist, enabling this will not make them private; they need to be made private in individual repo settings.
Description
Added namespace access control feature:
Added public repo creation feature:
Related issues or tickets
ENGDOCS-3141
Reviews