[eval] Optionnally use the gateway for the llm as a judge#2092
Merged
dgageot merged 1 commit intodocker:mainfrom Mar 12, 2026
Merged
[eval] Optionnally use the gateway for the llm as a judge#2092dgageot merged 1 commit intodocker:mainfrom
dgageot merged 1 commit intodocker:mainfrom
Conversation
Signed-off-by: David Gageot <david.gageot@docker.com>
dgageot
changed the title
![docker-agent[bot]](https://avatars.githubusercontent.com/in/2787757?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Summary
Assessment: 🟢 APPROVE
Summary
This PR adds optional gateway support for the LLM judge by conditionally configuring the WithGateway option when ModelsGateway is set. The implementation is clean and follows the existing pattern already established in eval.go:createJudgeModel.
Key observations:
- ✅ Options slice is properly initialized with
WithStructuredOutput - ✅ Gateway option is conditionally appended only when
ModelsGatewayis non-empty - ✅ Options are correctly passed as variadic arguments to
provider.New - ✅ Follows the identical pattern used elsewhere in the codebase (eval.go lines 745-748)
- ✅ No race conditions, resource leaks, or error handling issues introduced
Findings
No bugs found in the changed code. The implementation is correct and ready to merge.
gtardif
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.