Skip to content

fix: exclude hook_test.go from Windows builds and propagate ExecStart error in runWaitExec #13683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pawannn wants to merge 2 commits into
base: main
Choose a base branch
from
+3 −1
Open

fix: exclude hook_test.go from Windows builds and propagate ExecStart error in runWaitExec #13683

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2eef591
fix: add build tag to hook_test.go to fix Windows build failure (#13682)
pawannn Mar 27, 2026
d199446
fix: return error from ExecStart instead of nil in runWaitExec
pawannn Mar 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/compose/hook.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ func (s composeService) runWaitExec(ctx context.Context, execID string, service
TTY: service.Tty,
})
if err != nil {
return nil
return err
}

// We miss a ContainerExecWait API
Expand Down
2 changes: 2 additions & 0 deletions pkg/compose/hook_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
//go:build !windows

/*
Copyright 2020 Docker Compose CLI authors

Expand Down