Fix potential nil pointer dereference in container event monitoring #13551
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Description
The condition for checking container restart state in
monitor.gohad incorrect operator precedence.The expression:
is evaluated as:
This means if
inspect.Stateisnil, theinspect.State.Runningcheck would be evaluated (because the left side of||could be false), causing a nil pointer dereference panic.The fix adds explicit parentheses to ensure the nil check guards both state fields:
Reproduction Scenario
This bug could be triggered when:
events.ActionDiecase)ContainerInspectreturns successfully but withState: nil(rare edge case)inspect.State.Restartingwould panic before even checking)While Docker typically always populates the
Statefield, defensive programming dictates that after checking for nil, both conditions should be guarded.Testing