compose: recreate container when mounted image digest changes #13549
+78
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndeloof
reviewed
Jan 23, 2026
Contributor
ndeloof
left a comment
ndeloof
left a comment
There was a problem hiding this comment.
I'm not a fan about using (yet another) labels for this.
As an alternative, I suggest compose could resolve digest for image used as volume source, and update service definition accordingly (comparable to docker compose config --resolve-image-digests). Doing so we get a service definition that can be compared with actual container state.
Until now, mustRecreate logic only checked for divergence in TypeVolume mounts but ignored TypeImage mounts. This inconsistency caused containers to erroneously retain stale images even after the source image was rebuilt. This commit updates ensureImagesExists to resolve image volume sources to their digests. This way, the ServiceHash (config hash) naturally changes when the underlying image digest changes, triggering recreation via the standard convergence logic. Fixes docker#13547 Signed-off-by: ibrahim yapar <74625807+ibrahimypr@users.noreply.github.com>
ibrahimypr
force-pushed
the
fix/image-mount-recreate
branch
from
38a9962 to
12e2cd1
Compare
Author
|
Thanks for the feedback! I've updated the implementation to resolve the image digest directly in the volume source. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Until now,
mustRecreatelogic only checked for divergence inTypeVolumemounts but ignoredTypeImagemounts. This inconsistency caused containers to erroneously retain stale images even after the source image was rebuilt.This commit introduces a new label
com.docker.compose.image.mountsthat tracks the digests of images used as mounts. The convergence logic is updated to verify this label, ensuring that containers are correctly recreated whenever the underlying image mount digest changes.Related issue
Fixes #13547