-
Notifications
You must be signed in to change notification settings - Fork 2.1k
docs: cdi isn't experimental #6162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: cdi isn't experimental #6162
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6162 +/- ##
==========================================
- Coverage 54.83% 54.82% -0.01%
==========================================
Files 364 364
Lines 30467 30467
==========================================
- Hits 16706 16703 -3
- Misses 12786 12789 +3
Partials 975 975 🚀 New features to boost your workflow:
|
|
Thank you for contributing! It appears your commit message is missing a DCO sign-off, We require all commit messages to have a There is no need to open a new pull request, but to fix this (and make CI pass), Unfortunately, it's not possible to do so through GitHub's web UI, so this needs You can find some instructions in the output of the DCO check (which can be found Steps to do so "roughly" come down to:
Sorry for the hassle (I wish GitHub would make this a bit easier to do), and let me know if you need help or more detailed instructions! |
|
(sorry for the canned reply above; saves me some writing 😂) Thanks! I think there's some more changes needed. Perhaps we should consider removing the
For the daemon, we should update the description for the daemon config.
The current example shows how to enable CDI; We kept support for the option to disable CDI for situations where it's not desirable (moby/moby#49963)
CDI spec directories:
/etc/cdi
/var/run/cdi
Discovered Devices:
cdi: docker.com/gpu=webgpu |
Signed-off-by: ArthurFlag <arthur.flageul@docker.com>
c69acc2 to
7e040d9
Compare
|
Thanks for the extra info, @thaJeztah 🙇 I edited the other docs you pointed me to, let me know if that works with you. |
thaJeztah
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!!

- What I did
Removed a note stating CDI is experimental. Closes docker/docs#22926.
- A picture of a cute animal (not mandatory but encouraged)