cli/command/container: remove redundant uses of strslice.StrSlice #6158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The strslice.StrSlice type is a string-slice with a custom JSON Unmarshal function to provide backward-compatibility with older API requests (see [moby@17d6f00] and [moby@ea4a067]). Given that the type is assigned implicitly through the fields on HostConfig, we can just use a regular []string instead. [moby@17d6f00]: moby/moby@17d6f00 [moby@ea4a067]: moby/moby@ea4a067 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
added
status/2-code-review
kind/refactor
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6158 +/- ##
==========================================
- Coverage 54.82% 54.82% -0.01%
==========================================
Files 364 364
Lines 30470 30467 -3
==========================================
- Hits 16706 16703 -3
Misses 12789 12789
Partials 975 975 🚀 New features to boost your workflow:
|
Benehiko
approved these changes
Jul 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The strslice.StrSlice type is a string-slice with a custom JSON Unmarshal function to provide backward-compatibility with older API requests (see moby@17d6f00 and moby@ea4a067).
Given that the type is assigned implicitly through the fields on HostConfig, we can just use a regular []string instead.
- A picture of a cute animal (not mandatory but encouraged)