improve plugins listing performance #4151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can slightly improve plugins listing by spawning a goroutine for each iteration. Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
crazy-max
force-pushed
the
improve-plugins-list
branch
from
13070fa to
89583b9
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #4151 +/- ##
=======================================
Coverage 59.03% 59.03%
=======================================
Files 287 287
Lines 24767 24778 +11
=======================================
+ Hits 14620 14627 +7
- Misses 9264 9267 +3
- Partials 883 884 +1 |
thaJeztah
added
status/2-code-review
process/cherry-pick
area/completion
kind/bugfix
thaJeztah
reviewed
Apr 1, 2023
| return p, nil | ||
| } | ||
| if cmd.HasAlias(p.Name) { | ||
| p.Err = NewPluginError("plugin %q duplicates an alias of builtin command %q", p.Name, cmd.Name()) |
Member
There was a problem hiding this comment.
Not related to this PR, but it looks like the only reason NewPluginError() is exported, is for it to be used in a test in docker info;
cli/cli/command/system/info_test.go
Line 224 in a0756c3
🤔
Member
|
@cpuguy83 @laurazard ptal 🤗 |
vvoland
approved these changes
Apr 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow-up #4147 (comment)
- What I did
We can slightly improve plugins listing by spawning a goroutine for each iteration.
- How I did it
- How to verify it
Also run this repro.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)