Skip to content

[23.0 backport] Add bash completion for available plugins #4092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
thaJeztah merged 1 commit into from
Mar 22, 2023
Merged

[23.0 backport] Add bash completion for available plugins #4092

thaJeztah merged 1 commit into from
Mar 22, 2023

Conversation

@crazy-max
Copy link
Member

@crazy-max crazy-max commented Mar 12, 2023 •
edited
Loading

@crazy-max crazy-max requested a review from albers as a code owner March 12, 2023 17:33
@codecov-commenter
Copy link

codecov-commenter commented Mar 12, 2023 •
edited
Loading

Codecov Report

Merging #4092 (ac70ebc) into 23.0 (288b6c7) will not change coverage.
The diff coverage is n/a.

❗ Current head ac70ebc differs from pull request most recent head d074538. Consider uploading reports for the commit d074538 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##             23.0    #4092   +/-   ##
=======================================
  Coverage   59.14%   59.14%           
=======================================
  Files         287      287           
  Lines       24738    24738           
=======================================
  Hits        14631    14631           
  Misses       9221     9221           
  Partials      886      886

@crazy-max crazy-max marked this pull request as draft March 13, 2023 15:43
@crazy-max crazy-max changed the title [23.0 backport] Add bash completion for docker-buildx plugin [23.0 backport] Add bash completion for available plugins Mar 13, 2023
@crazy-max crazy-max force-pushed the 23.0_backport_buildx-completion branch 2 times, most recently from 37a67a5 to ac70ebc Compare March 14, 2023 21:58
@crazy-max
Add bash completion for available plugins
d074538 
Signed-off-by: CrazyMax <github@crazymax.dev>
(cherry picked from commit aa0aa4a)
@crazy-max crazy-max force-pushed the 23.0_backport_buildx-completion branch from ac70ebc to d074538 Compare March 17, 2023 14:06
@crazy-max crazy-max marked this pull request as ready for review March 21, 2023 12:06
@thaJeztah thaJeztah added this to the 23.0.2 milestone Mar 21, 2023
thaJeztah
thaJeztah approved these changes Mar 21, 2023
View reviewed changes
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

albers
albers approved these changes Mar 21, 2023
View reviewed changes
Copy link
Collaborator

@albers albers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah merged commit 6a8406e into docker:23.0 Mar 22, 2023
@crazy-max crazy-max deleted the 23.0_backport_buildx-completion branch March 22, 2023 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thaJeztah thaJeztah thaJeztah approved these changes

@albers albers albers approved these changes

Assignees

No one assigned

Labels

area/completion impact/changelog kind/enhancement status/2-code-review

Projects

None yet

Milestone

23.0.2

Development

Successfully merging this pull request may close these issues.

5 participants

@crazy-max @codecov-commenter @thaJeztah @albers @neersighted