cli: do not apply configfile's psFormat when --quiet is passed #4040
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a custom `psFormat` is set in the config file, the `--quiet` flag was ignored. Signed-off-by: Lionel Nicolas <lionel.nicolas@nividic.org>
Member
|
Looks like this is doing (roughly) the same as #3666 😅 |
Author
|
@thaJeztah Oh yeah sorry haha, I haven't seen this other PR. Any reason why it have not been merged yet ? |
Author
|
I can close my PR if you have plans to merge #3666 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
My vscode was failing to start/create devcontainers after I upgrade docker-ce from 20.10 to 23.0. I realized that table headers were shown in the logs when vscode was running
docker ps -q -a --filter label=vsch.local.folder=........ Manually runningdocker ps -aqconfirmed the issue (the full formatted container list was shown).- How I did it
As I have a custom
psFormatin my~/.docker/config.json, I removed it and after thatdocker ps -aqbehaved correctly.- How to verify it
For example, add
"psFormat": "table {{.ID}}\t{{.Image}}\t{{.Status}}\t{{.Ports}}\t{{.Names}}"to your~/.docker/config.jsonand try to rundocker ps -aq.- Description for the changelog
Fix
--quietflag being ignored when a custompsFormatis set in the config file- A picture of a cute animal (not mandatory but encouraged)