Skip to content

Conversation

@neersighted
Copy link
Member

- What I did

Simplify the graphdriver documentation to refer to the much more in-depth dedicated section, while also removing dated historical quirks and pushing people to overlay2.

@codecov-commenter
Copy link

codecov-commenter commented Feb 10, 2023

Codecov Report

Merging #4019 (e636747) into master (4254cd1) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4019   +/-   ##
=======================================
  Coverage   59.16%   59.16%           
=======================================
  Files         287      287           
  Lines       24724    24724           
=======================================
  Hits        14627    14627           
  Misses       9212     9212           
  Partials      885      885           

@neersighted
Copy link
Member Author

cc @dvdksn

@thaJeztah thaJeztah added this to the v-next milestone Feb 22, 2023
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall

left some comments / ramblings (happy to get feedback / thoughts on those)

Signed-off-by: Bjorn Neergaard <bneergaard@mirantis.com>
@neersighted neersighted force-pushed the graphdriver_misleading branch from cbf7dfd to e636747 Compare February 23, 2023 01:36
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@thaJeztah thaJeztah merged commit f5ac664 into docker:master Feb 23, 2023
@thaJeztah
Copy link
Member

@neersighted I added "cherry-pick" for this, as we publish the docs from the release-branches; let me know if you want to do the honours, otherwise I'll include it in a round of cherry-picks)

@neersighted neersighted deleted the graphdriver_misleading branch February 23, 2023 16:24
@neersighted
Copy link
Member Author

If you have a batch of docs updates go ahead, otherwise I can knock it out in a few minutes.

@thaJeztah
Copy link
Member

Haven't looked yet! So feel free to go ahead (if there's more docs cherry-picks, feel free to combine them)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants