Skip to content

fix: use run: step to correctly override GITHUB_EVENT_PATH in E2E mention tests #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
derekmisler wants to merge 2 commits into
base: main
Choose a base branch
from
+6 −8
Open

fix: use run: step to correctly override GITHUB_EVENT_PATH in E2E mention tests #222

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8ddf42d
fix: use run: step to correctly override GITHUB_EVENT_PATH in E2E test
derekmisler May 29, 2026
64f51a3
fix: use hyphenated INPUT_* env var names to match @actions/core getI…
derekmisler May 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions .github/workflows/test-e2e-reviewer.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,13 +113,12 @@ jobs:
- name: Run mention-reply handler
if: steps.fork-check.outputs.is_fork != 'true'
id: mention-handler
uses: ./.github/actions/mention-reply
env:
GITHUB_EVENT_PATH: /tmp/test-event-toplevel.json
GITHUB_EVENT_NAME: issue_comment
with:
github-token: ${{ env.GITHUB_APP_TOKEN || github.token }}
org-membership-token: ${{ env.ORG_MEMBERSHIP_TOKEN || github.token }}
INPUT_GITHUB-TOKEN: ${{ env.GITHUB_APP_TOKEN || github.token }}
INPUT_ORG-MEMBERSHIP-TOKEN: ${{ env.ORG_MEMBERSHIP_TOKEN || github.token }}
run: node ./dist/mention-reply.js

- name: Run mention reply
if: steps.fork-check.outputs.is_fork != 'true' && steps.mention-handler.outputs.should-reply == 'true'
Expand Down Expand Up @@ -241,13 +240,12 @@ jobs:
- name: Run mention-reply handler
if: steps.fork-check.outputs.is_fork != 'true'
id: mention-handler
uses: ./.github/actions/mention-reply
env:
GITHUB_EVENT_PATH: /tmp/test-event-inline.json
GITHUB_EVENT_NAME: pull_request_review_comment
with:
github-token: ${{ env.GITHUB_APP_TOKEN || github.token }}
org-membership-token: ${{ env.ORG_MEMBERSHIP_TOKEN || github.token }}
INPUT_GITHUB-TOKEN: ${{ env.GITHUB_APP_TOKEN || github.token }}
INPUT_ORG-MEMBERSHIP-TOKEN: ${{ env.ORG_MEMBERSHIP_TOKEN || github.token }}
run: node ./dist/mention-reply.js

- name: Run mention reply
if: steps.fork-check.outputs.is_fork != 'true' && steps.mention-handler.outputs.should-reply == 'true'
Expand Down
Loading