Fix false positive secret detection and verbose output extraction #20
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves https://github.com/docker/agentcatalog/issues/36
Summary
secret-patterns.sh)Changes
False Positive Fix (
security/sanitize-output.sh)When reviewing PRs containing security scanning code, the regex patterns themselves would trigger false positives. For example, the literal string
'ghs_[a-zA-Z0-9]{36}'in a diff would match the grep pattern.Now the scanner:
[]{}()*+?^$\)Verbose Output Fix (
action.yml)Added filters to remove agent internal content from extracted output:
msg=log messages--- Agent:/--- Tool:markers<thinking>/</thinking>XML tags[thinking]/[/thinking]bracket tagsThinking:prefixed contentTests (
tests/test-security.sh)Added two new test cases: