Use always-increasing CDV when debug mode is on#7298
Closed
bdukes wants to merge 1 commit into
Closed
Conversation
| if (clientResourceSettings != null) | ||
| if (hostSettings.DebugMode) | ||
| { | ||
| this.crmVersion = int.Parse($"{DateTime.UtcNow:HHmmssfff}", NumberStyles.None, CultureInfo.InvariantCulture); |
Contributor
There was a problem hiding this comment.
Suggested change
| this.crmVersion = int.Parse($"{DateTime.UtcNow:HHmmssfff}", NumberStyles.None, CultureInfo.InvariantCulture); | |
| this.crmVersion = int.Parse($"{DateTime.UtcNow:MMddyyyyHHmmssfff}", NumberStyles.None, CultureInfo.InvariantCulture); |
Maybe a bit of overkill, but this guarantees uniqueness across multiple days.
I do perfer the change here with the CRM version attribute/value
Contributor
Author
There was a problem hiding this comment.
I was trying to keep it to nine digits so that it was inside the bounds of an Int32 value. We could take off ff from the end and add dd to the front…
Contributor
|
I think #7299 might be fine by me, it will wrap in 2028 or something and start increasing from int.MinValue for the next 2038 years ;) |
Contributor
Author
|
Closing in favor of #7299 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7296