Open
Conversation
valadas
approved these changes
Mar 4, 2026
Contributor
valadas
left a comment
valadas
left a comment
There was a problem hiding this comment.
Wow, that is quite impressive! I am just wondering if it is worth all this effort to compress CSS where we have now most of it built with more modern tooling... Also YUI had no updates now for 6 years, so it might do stuff to support browsers we no longer care about and be less efficient than more recently maintained tooling...
I am not against this change though, just thinking out loud...
Contributor
Author
|
Agreed, long-term I think removing or replacing this compression makes sense. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes
DotNetNuke.MSBuild.Tasks.dlland its dependencies, replacing them with the one task that was used from it inline in thePackage.targetsfile.