Bulk Install: Add filtering and paging to event log#7043
Open
bdukes wants to merge 4 commits intofeature/bulk-installfrom
Open
Bulk Install: Add filtering and paging to event log#7043bdukes wants to merge 4 commits intofeature/bulk-installfrom
bdukes wants to merge 4 commits intofeature/bulk-installfrom
Conversation
valadas
approved these changes
Feb 27, 2026
Comment on lines
+15
to
+40
| function* makePagesIterator(current: number, lastIndex: number) { | ||
| const start = Math.max(current - 5, 0); | ||
| const end = Math.min(start + 10, lastIndex); | ||
| if (start !== 0) { | ||
| yield toPageItem(0, current); | ||
| if (start === 2) { | ||
| yield toPageItem(1, current); | ||
| } else if (start !== 1) { | ||
| yield ellipsisItem; | ||
| } | ||
| } | ||
|
|
||
| for (let i = start; i <= end; i++) { | ||
| yield toPageItem(i, current); | ||
| } | ||
|
|
||
| if (end !== lastIndex) { | ||
| if (end === lastIndex - 2) { | ||
| yield toPageItem(lastIndex - 1, current); | ||
| } else if (end !== lastIndex - 1) { | ||
| yield ellipsisItem; | ||
| } | ||
|
|
||
| yield toPageItem(lastIndex, current); | ||
| } | ||
| } |
bdukes
force-pushed
the
bulk-install-event-log-paging
branch
from
32039ce to
a643378
Compare
Name the store import store instead of state Move store import to the top of the local imports Move local model import to the bottom of the import list
Only show about 11 pages, plus first and last with ellipsis filling gaps
bdukes
force-pushed
the
bulk-install-event-log-paging
branch
from
a643378 to
f7f12ae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is part of the ongoing effort for #5920.
Since this is a feature branch, I will self-approve this PR.
This PR adds the ability to filter the Bulk Install event log by Severity and Event Type, as well as paging links:
Theoretically, Bulk Install has four severity levels, but only two are used (Info and Warning). Also, since its custom API auth was replaced with API Tokens (see #7033), there are not logs about authentication issues here (only IP safelist violations). This opens to question to me of whether Bulk Install should have its own Event Log at all, or if it should just use DNN's event log (and then this entire tab could be removed).