Resolve more warnings #6861
Merged
Resolve more warnings #6861
+21,184
−19,464
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdukes
force-pushed
the
resolve-warnings
branch
5 times, most recently
from
363a616 to
5cb927d
Compare
bdukes
force-pushed
the
resolve-warnings
branch
2 times, most recently
from
ee27e9f to
80067e0
Compare
mitchelsellers
approved these changes
Jan 6, 2026
bdukes
force-pushed
the
resolve-warnings
branch
2 times, most recently
from
01ab517 to
60c619b
Compare
valadas
requested changes
Jan 6, 2026
Contributor
valadas
left a comment
valadas
left a comment
There was a problem hiding this comment.
I get Could not load file or assembly 'System.Memory, Version=4.0.2.0 upon install for this build...
Contributor
|
@bdukes I think we need to remove that library from installExclude here https://github.com/bdukes/Dnn.Platform/blob/60c619b144051f4dea6a85e20ea22b4023d97c99/Build/Tasks/packaging.json#L52 |
bdukes
force-pushed
the
resolve-warnings
branch
2 times, most recently
from
45fc5c7 to
d611756
Compare
…tly strong Allow specifying algorithm in EncryptAES
bdukes
force-pushed
the
resolve-warnings
branch
from
d611756 to
7eec1ce
Compare
bdukes
force-pushed
the
resolve-warnings
branch
from
7eec1ce to
db00681
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Follow up to #6852
This PR resolves warnings introduced by #6846