Conversation
Pinned tabs are now separated from regular tabs and displayed in their own collapsible group at the top of the list, with a group checkbox for bulk select/deselect. This makes pinned tabs visually distinct and easier to manage, consistent with how tab groups are displayed. Fixes #2 https://claude.ai/code/session_01Gnb99bUrYzaG5Md65VGB9V
📝 WalkthroughWalkthroughThis pull request adds visual separation for pinned tabs by introducing a CSS indicator class and modifying the rendering flow in JavaScript to display pinned tabs as a distinct group, separate from grouped and ungrouped tabs, with new helper functions to manage their display. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Important Action Needed: IP Allowlist UpdateIf your organization protects your Git platform with IP whitelisting, please add the new CodeRabbit IP address to your allowlist:
Reviews will stop working after February 8, 2026 if the new IP is not added to your allowlist. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@popup/popup.css`:
- Around line 264-270: The .pinned-indicator rule uses hardcoded 10px for
width/height; define a CSS variable --indicator-size in :root (or reuse an
appropriate existing size var) and replace the hardcoded values in
.pinned-indicator with that variable (use var(--indicator-size)) so the
indicator follows the project's size tokens and can be adjusted centrally.
| .pinned-indicator { | ||
| width: 10px; | ||
| height: 10px; | ||
| border-radius: 50%; | ||
| flex-shrink: 0; | ||
| background-color: var(--text-secondary); | ||
| } |
There was a problem hiding this comment.
Use a size variable for the pinned indicator.
Hardcoded 10px bypasses the size variables used elsewhere; consider defining a dedicated --indicator-size in :root and reuse it here.
♻️ Suggested change
:root {
/* sizes */
--popup-width: 320px;
--popup-max-height: 500px;
--icon-size: 16px;
--border-radius: 4px;
+ --indicator-size: 10px;
}.pinned-indicator {
- width: 10px;
- height: 10px;
+ width: var(--indicator-size);
+ height: var(--indicator-size);
border-radius: 50%;
flex-shrink: 0;
background-color: var(--text-secondary);
}As per coding guidelines: Use CSS variables defined in :root for colors, spacing, and sizes in CSS files.
🤖 Prompt for AI Agents
In `@popup/popup.css` around lines 264 - 270, The .pinned-indicator rule uses
hardcoded 10px for width/height; define a CSS variable --indicator-size in :root
(or reuse an appropriate existing size var) and replace the hardcoded values in
.pinned-indicator with that variable (use var(--indicator-size)) so the
indicator follows the project's size tokens and can be adjusted centrally.
Pinned tabs are now separated from regular tabs and displayed in their
own collapsible group at the top of the list, with a group checkbox for
bulk select/deselect. This makes pinned tabs visually distinct and
easier to manage, consistent with how tab groups are displayed.
Fixes #2
Summary by CodeRabbit