fix: gc #628
Merged
fix: gc #628
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnlup
commented
Feb 17, 2025
lib/gc.js
Outdated
| * https://github.com/nodejs/node/blob/cdad3d8fe5f468aec6549fd59db73a3bfe063e3c/lib/internal/histogram.js#L283-L284 | ||
| */ | ||
| this[kHistogram].record(Math.trunc(ns)) | ||
| const val = Math.floor(ns) |
Owner
Author
There was a problem hiding this comment.
@andrewpuch Here we don't truncate anymore, but didn't see any difference, do you see any issues with it?
Owner
Author
There was a problem hiding this comment.
Sorry, there's round not floor I have forced pushed.
dnlup
force-pushed
the
627-the-value-of-val-is-out-of-range
branch
from
f5fad20 to
c928539
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix "the-value-of-val-is-out-of-range" error.
Closes #627 .