Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #100.
Summary
$$schemaaccept schemas created before a module reloadschema.jstwice via distinct module URLsWhy this approach
schemaStoreis global, so$type("...")can return a schema instance created by an earlier evaluation ofschema.js.After a module reload, that cached schema no longer passes
instanceof Schemaagainst the new constructor, which causes$()/$union(...)to throwUnexpected case.This patch makes schema recognition reload-stable by adding a global symbol marker to
Schema.prototypeand accepting that marker in$$schemain addition toinstanceof Schema.A broader redesign around branding all schema objects more explicitly may also make sense, but that would be a larger architectural change. This PR keeps the fix minimal and targeted to the actual reload mismatch.
Verification
node --unhandled-rejections=strict ./src/test.js --filter 'schema: schema reload stability'npx standard src/schema.js src/schema.test.js